Skip to content

Bug: Node's block height is not logged after applying snapshot #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
capt4ce opened this issue Apr 20, 2020 · 0 comments · Fixed by #762
Closed

Bug: Node's block height is not logged after applying snapshot #759

capt4ce opened this issue Apr 20, 2020 · 0 comments · Fixed by #762
Assignees
Labels
BUG Something isn't working
Milestone

Comments

@capt4ce
Copy link
Contributor

capt4ce commented Apr 20, 2020

Description

The call for logger that logs the block height to prometheus is located in the blockPush method. Meanwhile the implementation of applying snapshot is not using blockPush. Because of this, the block height of the node that just applied a snapshot is not logged, it should wait for the node to apply blockPush on the next block.

Steps to reproduce

  1. Run a node that downloads and apply a snapshot
  2. Observe that in the prometheus metrics the height metric is not updated unless it applies the next block.

Expected behavior

Once a snapshot has been applied, Prometheus needs to know about the update of the blockchain state.

@capt4ce capt4ce added the BUG Something isn't working label Apr 20, 2020
@capt4ce capt4ce self-assigned this Apr 20, 2020
@capt4ce capt4ce added this to the Milestone 14 milestone Apr 20, 2020
@capt4ce capt4ce mentioned this issue Apr 20, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant