Skip to content

Bug: Nodes are stuck in a specific heights when all the nodes are having same height #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
capt4ce opened this issue Apr 24, 2020 · 0 comments · Fixed by #781
Closed

Bug: Nodes are stuck in a specific heights when all the nodes are having same height #780

capt4ce opened this issue Apr 24, 2020 · 0 comments · Fixed by #781
Assignees
@capt4ce
Labels
BACKWARD_COMPATIBLE require changes that are backward compatible, no reset required BUG Something isn't working HIGH_PRIORITY needed ASAP for current sprint
Milestone
Milestone 16

Comments

@capt4ce
Copy link
Contributor

capt4ce commented Apr 24, 2020

Description

This bug was found by @andy-shi88 that is caused by the recent change in deciding whether the node has finished downloading the blocks. It is because the added validation exists before the main validation.

Steps to reproduce

  1. start multiple node locally
  2. observe that when they are at the same height, they will stuck for sometime

Expected behavior

the waiting algorithm should only be executed when the node is at height 0
@capt4ce capt4ce added BUG Something isn't working BACKWARD_COMPATIBLE require changes that are backward compatible, no reset required HIGH_PRIORITY needed ASAP for current sprint labels Apr 24, 2020
@capt4ce capt4ce added this to the Milestone 16 milestone Apr 24, 2020
@capt4ce capt4ce self-assigned this Apr 24, 2020
@capt4ce capt4ce mentioned this issue Apr 24, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capt4ce capt4ce

Labels
BACKWARD_COMPATIBLE require changes that are backward compatible, no reset required BUG Something isn't working HIGH_PRIORITY needed ASAP for current sprint
Projects
None yet
Milestone
Milestone 16
Development

Successfully merging a pull request may close this issue.

move the validation of download finish if the block height is 0 zoobc/zoobc-core
1 participant
@capt4ce