Skip to content

Bug: Delete Badger:MempoolBackup After Invalid Trial #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
andy-shi88 opened this issue May 5, 2020 · 0 comments · Fixed by #811
Closed
2 tasks

Bug: Delete Badger:MempoolBackup After Invalid Trial #801

andy-shi88 opened this issue May 5, 2020 · 0 comments · Fixed by #811
Assignees
@astaphobia
Labels
BACKWARD_COMPATIBLE require changes that are backward compatible, no reset required BUG Something isn't working CORE core functionalities LOW_PRIORITY can be postponed
Milestone
Milestone 17

Comments

@andy-shi88
Copy link
Contributor

andy-shi88 commented May 5, 2020 •
edited by astaphobia
Loading

Description

In restoreMempoolsBackup function node will try to restore the mempool byte from badger db.

However if the mempool is duplicated, it never delete the backup, which cause this process to repeat and repeat again until we manually flush the kv_db data.

Expected behavior

When restoreMempoolsBackup detect DuplicateMempool it should delete the backup byte.

  • Remove duplicated mempools on badger
  • KVDBExecutor Delete method
@andy-shi88 andy-shi88 added BUG Something isn't working CORE core functionalities BACKWARD_COMPATIBLE require changes that are backward compatible, no reset required LOW_PRIORITY can be postponed labels May 5, 2020
@andy-shi88 andy-shi88 added this to the Milestone 16 milestone May 5, 2020
@astaphobia astaphobia self-assigned this May 6, 2020
@capt4ce capt4ce modified the milestones: Milestone 16, Milestone 17 May 6, 2020
@astaphobia astaphobia mentioned this issue May 8, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astaphobia astaphobia

Labels
BACKWARD_COMPATIBLE require changes that are backward compatible, no reset required BUG Something isn't working CORE core functionalities LOW_PRIORITY can be postponed
Projects
None yet
Milestone
Milestone 17
Development

Successfully merging a pull request may close this issue.

Remove key from badger db after mempools backup restored zoobc/zoobc-core
3 participants
@astaphobia @capt4ce @andy-shi88