Skip to content

Tech: node registration - schema: grpc service methods and attachment for node registration processes #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iltoga opened this issue Jul 22, 2019 · 0 comments · Fixed by #88 or #100
Closed

Tech: node registration - schema: grpc service methods and attachment for node registration processes #82

iltoga opened this issue Jul 22, 2019 · 0 comments · Fixed by #88 or #100
Assignees
@iltoga
Labels
FEATURE New feature or request
Milestone
Sprint 2

Comments

@iltoga
Copy link
Contributor

iltoga commented Jul 22, 2019 •
edited
Loading

Description

Implementing proto model for node registration transaction's attachment: one attachment for registration,update,remove,claim should be sufficient and grpc service methods ( /update/remove/claim) for api endpoints

Breakdown

  • Refactor nodeRegistration.proto model adding attachment message (trying with one attachement for all noderegistration apis first)
    • nodePublicKey: node pub key
    • lockedBalance: amount to be locked
    • nodeAddress: node address (IP address or domain name)
    • accountType: node owner account type
    • accountAddress: node owner account address
    • poown: proof of ownership message (get message structure from proof of ownership proto message, that should be something like the following):
      • accountType: account type
      • accountAddress: account address
      • blockHash: block hash of a recent block (when generated this is the node's last known block)
      • blockHeight: block height
      • signature: signature on all the above (by the node's private key)

Additional Diagram / File

Reference

#68
@iltoga iltoga added the FEATURE New feature or request label Jul 22, 2019
@iltoga iltoga added this to the Sprint 2 milestone Jul 22, 2019
@iltoga iltoga self-assigned this Jul 22, 2019
This was referenced Jul 22, 2019
Closed
Closed
Closed
Closed
iltoga pushed a commit that referenced this issue Jul 22, 2019
#82 - recompiled schema after adding node registration message and fi…
cbc9150 
…xing bug in accountBalance request message
@iltoga iltoga mentioned this issue Jul 22, 2019
Merged
andy-shi88 pushed a commit that referenced this issue Jul 22, 2019
@iltoga @andy-shi88
#82 - updated-recompiled the schema after adding node registration tx…
e8ecc08 
… body proto message (#88)

* #82 - recompiled schema after adding node registration message and fixing bug in accountBalance request message

* recompiled schema after adding queued to noderegistration message

* fixed wrong data type for queued field
astaphobia pushed a commit that referenced this issue Jul 24, 2019
@iltoga @astaphobia
75 generalise tx validation (#93)
78920da 
* #82 - recompiled schema after adding node registration message and fixing bug in accountBalance request message
* fixed wrong data type for queued field
* added util function to validate an account address
added new tx type for node registration (2,0)
WIP: implementation of (new) nodeRegistration transaction workflow
refactored some noderegistration query
fixed accountBalanceQuery: missing interface signature for ExtractModel and missing method for BuildModel
* refactored InsertNodeRegistration query
* implemented generic tx validation (util)
moved transactionUtil functions to common
separated generic tx from txType-specific validation logic
WIP: noderegistration txType
* commented out signature validation because of circular dependency
* fixed bug in addmempooltransaction
@andy-shi88 andy-shi88 mentioned this issue Aug 1, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iltoga iltoga

Labels
FEATURE New feature or request
Projects
None yet
Milestone
Sprint 2
1 participant
@iltoga