Skip to content

Tech: update node registration - transaction's business logic for 'update node registration' transaction type #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iltoga opened this issue Jul 22, 2019 · 0 comments · Fixed by #130 or #142
Closed

Tech: update node registration - transaction's business logic for 'update node registration' transaction type #84

iltoga opened this issue Jul 22, 2019 · 0 comments · Fixed by #130 or #142
Assignees
@iltoga
Labels
CORE core functionalities FEATURE New feature or request
Milestone
Sprint 3

Comments

@iltoga
Copy link
Contributor

iltoga commented Jul 22, 2019

Description

Implement service layer for update node registration's transaction type, as described in https://docs.google.com/document/d/118CdR0WOIpZx4C9Hnx-JsrHz3vXn9OZ6eMokk9y71hk/edit#bookmark=id.nw9gxr2k51oa

Breakdown

Additional Diagram / File

Reference

#68 #82
@iltoga iltoga added the FEATURE New feature or request label Jul 22, 2019
@iltoga iltoga added this to the Sprint 2 milestone Jul 22, 2019
@iltoga iltoga self-assigned this Jul 22, 2019
@andy-shi88 andy-shi88 modified the milestones: Sprint 2, Sprint 3 Aug 1, 2019
@andy-shi88 andy-shi88 added the CORE core functionalities label Aug 2, 2019
@iltoga iltoga mentioned this issue Aug 6, 2019
Merged
3 tasks
andy-shi88 added a commit that referenced this issue Aug 8, 2019
@andy-shi88
#84 remove cyclomatic rule as agreed on consensus
247d1e9
andy-shi88 added a commit that referenced this issue Aug 8, 2019
@andy-shi88
#84 update reviewed code
7385652
andy-shi88 added a commit that referenced this issue Aug 8, 2019
@andy-shi88
#84 delete duplicate function due to merge
620fd27
astaphobia pushed a commit that referenced this issue Aug 8, 2019
@iltoga @astaphobia
84 update node registration (#130)
31af4b4 
* added id and changed pri key to id to node

* fixed node_registry table pri key

* added update node registration query and test. recompiled schema adding node_registry id field

* recompiled schema: added updatenoderegistration request and rpc endpoint to schema

* recompiled schema: refactored updateNodeRegistration and added UpdateNodeRegistrationTransactionBody to transaction.proto

* first implementation of updateNodeRegistration: queries and transaction body struct/validation/applyunconfirmed/applyconfirmed

* added fixtureGenerator for tests
added Get/Parse bytes to TypeAction interface
TODO: interface  for transactionBody to be returned by ParseBodyBytes

* #83 cast transaction body interface to specific body implementation

* refactored common/util get/parse transaction bytes in respect to new standards
started refactoring unit tests

* #84 remove cyclomatic rule as agreed on consensus
@iltoga iltoga mentioned this issue Aug 14, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iltoga iltoga

Labels
CORE core functionalities FEATURE New feature or request
Projects
None yet
Milestone
Sprint 3
2 participants
@iltoga @andy-shi88