Skip to content

Commit 7a1280d

Browse files
committed
compose test [nfc]: Add a parent test group
This will make it ready for the next commit(s) where we add another sub-group test.
1 parent 8681178 commit 7a1280d

File tree

1 file changed

+64
-62
lines changed

1 file changed

+64
-62
lines changed

test/widgets/compose_box_test.dart

Lines changed: 64 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ void main() {
580580
});
581581
});
582582

583-
group('compose box in DMs with deactivated users', () {
583+
group('error banner', () {
584584
Finder contentFieldFinder() => find.descendant(
585585
of: find.byType(ComposeBox),
586586
matching: find.byType(TextField));
@@ -607,81 +607,83 @@ void main() {
607607
checkBanner(isShown: !isShown);
608608
}
609609

610-
Future<void> changeUserStatus(WidgetTester tester,
611-
{required User user, required bool isActive}) async {
612-
await store.handleEvent(RealmUserUpdateEvent(id: 1,
613-
userId: user.userId, isActive: isActive));
614-
await tester.pump();
615-
}
610+
group('in DMs with deactivated users', () {
611+
Future<void> changeUserStatus(WidgetTester tester,
612+
{required User user, required bool isActive}) async {
613+
await store.handleEvent(RealmUserUpdateEvent(id: 1,
614+
userId: user.userId, isActive: isActive));
615+
await tester.pump();
616+
}
616617

617-
DmNarrow dmNarrowWith(User otherUser) => DmNarrow.withUser(otherUser.userId,
618-
selfUserId: eg.selfUser.userId);
618+
DmNarrow dmNarrowWith(User otherUser) => DmNarrow.withUser(otherUser.userId,
619+
selfUserId: eg.selfUser.userId);
619620

620-
DmNarrow groupDmNarrowWith(List<User> otherUsers) => DmNarrow.withOtherUsers(
621-
otherUsers.map((u) => u.userId), selfUserId: eg.selfUser.userId);
621+
DmNarrow groupDmNarrowWith(List<User> otherUsers) => DmNarrow.withOtherUsers(
622+
otherUsers.map((u) => u.userId), selfUserId: eg.selfUser.userId);
622623

623-
group('1:1 DMs', () {
624-
testWidgets('compose box replaced with a banner', (tester) async {
625-
final deactivatedUser = eg.user(isActive: false);
626-
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
627-
users: [deactivatedUser]);
628-
checkComposeBox(isShown: false);
629-
});
624+
group('1:1 DMs', () {
625+
testWidgets('compose box replaced with a banner', (tester) async {
626+
final deactivatedUser = eg.user(isActive: false);
627+
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
628+
users: [deactivatedUser]);
629+
checkComposeBox(isShown: false);
630+
});
630631

631-
testWidgets('active user becomes deactivated -> '
632-
'compose box is replaced with a banner', (tester) async {
633-
final activeUser = eg.user(isActive: true);
634-
await prepareComposeBox(tester, narrow: dmNarrowWith(activeUser),
635-
users: [activeUser]);
636-
checkComposeBox(isShown: true);
632+
testWidgets('active user becomes deactivated -> '
633+
'compose box is replaced with a banner', (tester) async {
634+
final activeUser = eg.user(isActive: true);
635+
await prepareComposeBox(tester, narrow: dmNarrowWith(activeUser),
636+
users: [activeUser]);
637+
checkComposeBox(isShown: true);
637638

638-
await changeUserStatus(tester, user: activeUser, isActive: false);
639-
checkComposeBox(isShown: false);
640-
});
639+
await changeUserStatus(tester, user: activeUser, isActive: false);
640+
checkComposeBox(isShown: false);
641+
});
641642

642-
testWidgets('deactivated user becomes active -> '
643-
'banner is replaced with the compose box', (tester) async {
644-
final deactivatedUser = eg.user(isActive: false);
645-
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
646-
users: [deactivatedUser]);
647-
checkComposeBox(isShown: false);
643+
testWidgets('deactivated user becomes active -> '
644+
'banner is replaced with the compose box', (tester) async {
645+
final deactivatedUser = eg.user(isActive: false);
646+
await prepareComposeBox(tester, narrow: dmNarrowWith(deactivatedUser),
647+
users: [deactivatedUser]);
648+
checkComposeBox(isShown: false);
648649

649-
await changeUserStatus(tester, user: deactivatedUser, isActive: true);
650-
checkComposeBox(isShown: true);
650+
await changeUserStatus(tester, user: deactivatedUser, isActive: true);
651+
checkComposeBox(isShown: true);
652+
});
651653
});
652-
});
653654

654-
group('group DMs', () {
655-
testWidgets('compose box replaced with a banner', (tester) async {
656-
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
657-
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
658-
users: deactivatedUsers);
659-
checkComposeBox(isShown: false);
660-
});
655+
group('group DMs', () {
656+
testWidgets('compose box replaced with a banner', (tester) async {
657+
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
658+
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
659+
users: deactivatedUsers);
660+
checkComposeBox(isShown: false);
661+
});
661662

662-
testWidgets('at least one user becomes deactivated -> '
663-
'compose box is replaced with a banner', (tester) async {
664-
final activeUsers = [eg.user(isActive: true), eg.user(isActive: true)];
665-
await prepareComposeBox(tester, narrow: groupDmNarrowWith(activeUsers),
666-
users: activeUsers);
667-
checkComposeBox(isShown: true);
663+
testWidgets('at least one user becomes deactivated -> '
664+
'compose box is replaced with a banner', (tester) async {
665+
final activeUsers = [eg.user(isActive: true), eg.user(isActive: true)];
666+
await prepareComposeBox(tester, narrow: groupDmNarrowWith(activeUsers),
667+
users: activeUsers);
668+
checkComposeBox(isShown: true);
668669

669-
await changeUserStatus(tester, user: activeUsers[0], isActive: false);
670-
checkComposeBox(isShown: false);
671-
});
670+
await changeUserStatus(tester, user: activeUsers[0], isActive: false);
671+
checkComposeBox(isShown: false);
672+
});
672673

673-
testWidgets('all deactivated users become active -> '
674-
'banner is replaced with the compose box', (tester) async {
675-
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
676-
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
677-
users: deactivatedUsers);
678-
checkComposeBox(isShown: false);
674+
testWidgets('all deactivated users become active -> '
675+
'banner is replaced with the compose box', (tester) async {
676+
final deactivatedUsers = [eg.user(isActive: false), eg.user(isActive: false)];
677+
await prepareComposeBox(tester, narrow: groupDmNarrowWith(deactivatedUsers),
678+
users: deactivatedUsers);
679+
checkComposeBox(isShown: false);
679680

680-
await changeUserStatus(tester, user: deactivatedUsers[0], isActive: true);
681-
checkComposeBox(isShown: false);
681+
await changeUserStatus(tester, user: deactivatedUsers[0], isActive: true);
682+
checkComposeBox(isShown: false);
682683

683-
await changeUserStatus(tester, user: deactivatedUsers[1], isActive: true);
684-
checkComposeBox(isShown: true);
684+
await changeUserStatus(tester, user: deactivatedUsers[1], isActive: true);
685+
checkComposeBox(isShown: true);
686+
});
685687
});
686688
});
687689
});

0 commit comments

Comments
 (0)