Skip to content

Commit 7bd5bef

Browse files
chrisbobbegnprice
authored andcommitted
msglist [nfc]: Move DesignVariables.editedMovedMarkerCollapsed to here
1 parent beee77e commit 7bd5bef

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

lib/widgets/edit_state_marker.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import 'package:flutter/material.dart';
22

33
import '../api/model/model.dart';
44
import 'icons.dart';
5+
import 'message_list.dart';
56
import 'text.dart';
6-
import 'theme.dart';
77

88
class EditStateMarker extends StatelessWidget {
99
const EditStateMarker({
@@ -44,7 +44,7 @@ class _EditStateMarkerPill extends StatelessWidget {
4444

4545
@override
4646
Widget build(BuildContext context) {
47-
final designVariables = DesignVariables.of(context);
47+
final messageListTheme = MessageListTheme.of(context);
4848

4949
final IconData icon;
5050
final Offset offset;
@@ -69,6 +69,6 @@ class _EditStateMarkerPill extends StatelessWidget {
6969
child: Transform.translate(
7070
offset: offset,
7171
child: Icon(
72-
icon, size: 16, color: designVariables.editedMovedMarkerCollapsed)));
72+
icon, size: 16, color: messageListTheme.editedMovedMarkerCollapsed)));
7373
}
7474
}

lib/widgets/message_list.dart

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ class MessageListTheme extends ThemeExtension<MessageListTheme> {
3131
dateSeparator: Colors.black,
3232
dateSeparatorText: const HSLColor.fromAHSL(0.75, 0, 0, 0.15).toColor(),
3333
dmRecipientHeaderBg: const HSLColor.fromAHSL(1, 46, 0.35, 0.93).toColor(),
34+
editedMovedMarkerCollapsed: const Color.fromARGB(128, 146, 167, 182),
3435
messageTimestamp: const HSLColor.fromAHSL(0.8, 0, 0, 0.2).toColor(),
3536
recipientHeaderText: const HSLColor.fromAHSL(1, 0, 0, 0.15).toColor(),
3637
senderBotIcon: const HSLColor.fromAHSL(1, 180, 0.08, 0.65).toColor(),
@@ -57,6 +58,8 @@ class MessageListTheme extends ThemeExtension<MessageListTheme> {
5758
dateSeparator: Colors.white,
5859
dateSeparatorText: const HSLColor.fromAHSL(0.75, 0, 0, 1).toColor(),
5960
dmRecipientHeaderBg: const HSLColor.fromAHSL(1, 46, 0.15, 0.2).toColor(),
61+
// TODO(#95) need dark-theme color
62+
editedMovedMarkerCollapsed: const Color.fromARGB(128, 146, 167, 182),
6063
messageTimestamp: const HSLColor.fromAHSL(0.6, 0, 0, 1).toColor(),
6164
recipientHeaderText: const HSLColor.fromAHSL(0.8, 0, 0, 1).toColor(),
6265
senderBotIcon: const HSLColor.fromAHSL(1, 180, 0.05, 0.5).toColor(),
@@ -81,6 +84,7 @@ class MessageListTheme extends ThemeExtension<MessageListTheme> {
8184
required this.dateSeparator,
8285
required this.dateSeparatorText,
8386
required this.dmRecipientHeaderBg,
87+
required this.editedMovedMarkerCollapsed,
8488
required this.messageTimestamp,
8589
required this.recipientHeaderText,
8690
required this.senderBotIcon,
@@ -105,6 +109,7 @@ class MessageListTheme extends ThemeExtension<MessageListTheme> {
105109
final Color dateSeparator;
106110
final Color dateSeparatorText;
107111
final Color dmRecipientHeaderBg;
112+
final Color editedMovedMarkerCollapsed;
108113
final Color messageTimestamp;
109114
final Color recipientHeaderText;
110115
final Color senderBotIcon;
@@ -120,6 +125,7 @@ class MessageListTheme extends ThemeExtension<MessageListTheme> {
120125
Color? dateSeparator,
121126
Color? dateSeparatorText,
122127
Color? dmRecipientHeaderBg,
128+
Color? editedMovedMarkerCollapsed,
123129
Color? messageTimestamp,
124130
Color? recipientHeaderText,
125131
Color? senderBotIcon,
@@ -134,6 +140,7 @@ class MessageListTheme extends ThemeExtension<MessageListTheme> {
134140
dateSeparator: dateSeparator ?? this.dateSeparator,
135141
dateSeparatorText: dateSeparatorText ?? this.dateSeparatorText,
136142
dmRecipientHeaderBg: dmRecipientHeaderBg ?? this.dmRecipientHeaderBg,
143+
editedMovedMarkerCollapsed: editedMovedMarkerCollapsed ?? this.editedMovedMarkerCollapsed,
137144
messageTimestamp: messageTimestamp ?? this.messageTimestamp,
138145
recipientHeaderText: recipientHeaderText ?? this.recipientHeaderText,
139146
senderBotIcon: senderBotIcon ?? this.senderBotIcon,
@@ -155,6 +162,7 @@ class MessageListTheme extends ThemeExtension<MessageListTheme> {
155162
dateSeparator: Color.lerp(dateSeparator, other.dateSeparator, t)!,
156163
dateSeparatorText: Color.lerp(dateSeparatorText, other.dateSeparatorText, t)!,
157164
dmRecipientHeaderBg: Color.lerp(streamMessageBgDefault, other.dmRecipientHeaderBg, t)!,
165+
editedMovedMarkerCollapsed: Color.lerp(editedMovedMarkerCollapsed, other.editedMovedMarkerCollapsed, t)!,
158166
messageTimestamp: Color.lerp(messageTimestamp, other.messageTimestamp, t)!,
159167
recipientHeaderText: Color.lerp(recipientHeaderText, other.recipientHeaderText, t)!,
160168
senderBotIcon: Color.lerp(senderBotIcon, other.senderBotIcon, t)!,

lib/widgets/theme.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
136136
title: const Color(0xff1a1a1a),
137137
streamColorSwatches: StreamColorSwatches.light,
138138
star: const HSLColor.fromAHSL(0.5, 47, 1, 0.41).toColor(),
139-
editedMovedMarkerCollapsed: const Color.fromARGB(128, 146, 167, 182),
140139
);
141140

142141
DesignVariables.dark() :
@@ -149,8 +148,6 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
149148
streamColorSwatches: StreamColorSwatches.dark,
150149
// TODO(#95) unchanged in dark theme?
151150
star: const HSLColor.fromAHSL(0.5, 47, 1, 0.41).toColor(),
152-
// TODO(#95) need dark-theme color
153-
editedMovedMarkerCollapsed: const Color.fromARGB(128, 146, 167, 182),
154151
);
155152

156153
DesignVariables._({
@@ -161,7 +158,6 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
161158
required this.title,
162159
required this.streamColorSwatches,
163160
required this.star,
164-
required this.editedMovedMarkerCollapsed,
165161
});
166162

167163
/// The [DesignVariables] from the context's active theme.
@@ -185,7 +181,6 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
185181

186182
// Not named variables in Figma; taken from older Figma drafts, or elsewhere.
187183
final Color star;
188-
final Color editedMovedMarkerCollapsed;
189184

190185
@override
191186
DesignVariables copyWith({
@@ -196,7 +191,6 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
196191
Color? title,
197192
StreamColorSwatches? streamColorSwatches,
198193
Color? star,
199-
Color? editedMovedMarkerCollapsed,
200194
}) {
201195
return DesignVariables._(
202196
bgTopBar: bgTopBar ?? this.bgTopBar,
@@ -206,7 +200,6 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
206200
title: title ?? this.title,
207201
streamColorSwatches: streamColorSwatches ?? this.streamColorSwatches,
208202
star: star ?? this.star,
209-
editedMovedMarkerCollapsed: editedMovedMarkerCollapsed ?? this.editedMovedMarkerCollapsed,
210203
);
211204
}
212205

@@ -223,7 +216,6 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
223216
title: Color.lerp(title, other.title, t)!,
224217
streamColorSwatches: StreamColorSwatches.lerp(streamColorSwatches, other.streamColorSwatches, t),
225218
star: Color.lerp(star, other.star, t)!,
226-
editedMovedMarkerCollapsed: Color.lerp(editedMovedMarkerCollapsed, other.editedMovedMarkerCollapsed, t)!,
227219
);
228220
}
229221
}

0 commit comments

Comments
 (0)