Skip to content

Commit 9672a0a

Browse files
committed
compose test: Check ID still included if same-name users deactivated
While autocomplete does not include deactivated users, there still is a possibility that same-name users with one or more deactivated gets mentioned, which will make the mentioned user ambiguous without the id, this is explained in #451. This adds a test case that asserts same-name users are disambiguated while composing the message regardless of them being active. Fixes part of #451
1 parent 62015a2 commit 9672a0a

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

test/example_data.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ User user({
5959
int? userId,
6060
String? email,
6161
String? fullName,
62+
bool? isActive,
6263
String? avatarUrl,
6364
Map<int, ProfileFieldUserData>? profileData,
6465
}) {
@@ -68,7 +69,7 @@ User user({
6869
email: email ?? '[email protected]', // TODO generate example emails
6970
fullName: fullName ?? 'A user', // TODO generate example names
7071
dateJoined: '2023-04-28',
71-
isActive: true,
72+
isActive: isActive ?? true,
7273
isOwner: false,
7374
isAdmin: false,
7475
isGuest: false,

test/model/compose_test.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,11 @@ hello
316316
store.addUsers([user, eg.user(userId: 5), eg.user(userId: 234, fullName: user.fullName)]);
317317
check(mention(user, silent: true, users: store.users)).equals('@_**Full Name|123**');
318318
});
319+
test('`users` passed; has two same-name users but one of them is deactivated', () {
320+
final store = eg.store();
321+
store.addUsers([user, eg.user(userId: 5), eg.user(userId: 234, fullName: user.fullName, isActive: false)]);
322+
check(mention(user, silent: true, users: store.users)).equals('@_**Full Name|123**');
323+
});
319324
test('`users` passed; user has unique fullName', () {
320325
final store = eg.store();
321326
store.addUsers([user, eg.user(userId: 234, fullName: 'Another Name')]);

0 commit comments

Comments
 (0)