Skip to content

Commit cbed946

Browse files
about_zulip [nfc]: Refactor to use packageInfo getter on binding
1 parent 08323b7 commit cbed946

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

lib/widgets/about_zulip.dart

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:flutter/material.dart';
22
import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
3-
import 'package:package_info_plus/package_info_plus.dart';
43

4+
import '../model/binding.dart';
55
import 'page.dart';
66

77
class AboutZulipPage extends StatefulWidget {
@@ -16,22 +16,11 @@ class AboutZulipPage extends StatefulWidget {
1616
}
1717

1818
class _AboutZulipPageState extends State<AboutZulipPage> {
19-
PackageInfo? _packageInfo;
20-
21-
@override
22-
void initState() {
23-
super.initState();
24-
(() async {
25-
final result = await PackageInfo.fromPlatform();
26-
setState(() {
27-
_packageInfo = result;
28-
});
29-
})();
30-
}
31-
3219
@override
3320
Widget build(BuildContext context) {
3421
final zulipLocalizations = ZulipLocalizations.of(context);
22+
final appVersion = ZulipBinding.instance.packageInfo.version;
23+
3524
return Scaffold(
3625
appBar: AppBar(title: Text(zulipLocalizations.aboutPageTitle)),
3726
body: SingleChildScrollView(
@@ -43,7 +32,7 @@ class _AboutZulipPageState extends State<AboutZulipPage> {
4332
child: Column(mainAxisAlignment: MainAxisAlignment.center, children: [
4433
ListTile(
4534
title: Text(zulipLocalizations.aboutPageAppVersion),
46-
subtitle: Text(_packageInfo?.version ?? '(…)')),
35+
subtitle: Text(appVersion)),
4736
ListTile(
4837
title: Text(zulipLocalizations.aboutPageOpenSourceLicenses),
4938
subtitle: Text(zulipLocalizations.aboutPageTapToView),

0 commit comments

Comments
 (0)