autocomplete [nfc]: Explain why no [AutocompleteViewManager.dispose]

gnprice · gnprice · commit ebf41f29825f · 2024-05-06T17:07:57.000-07:00
diff --git a/lib/model/autocomplete.dart b/lib/model/autocomplete.dart
@@ -154,6 +154,13 @@ class AutocompleteViewManager {
       view.reassemble();
     }
   }
+
+  // No `dispose` method, because there's nothing for it to do.
+  // The [MentionAutocompleteView]s are owned by (i.e., they get [dispose]d by)
+  // the UI code that manages the autocomplete interaction, including in the
+  // case where the [PerAccountStore] is replaced.  Discussion:
+  //   https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.60MentionAutocompleteView.2Edispose.60/near/1791292
+  // void dispose() { … }
 }
 
 /// A view-model for a mention-autocomplete interaction.

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,13 @@ class AutocompleteViewManager {`
`154`	`154`	`view.reassemble();`
`155`	`155`	`}`
`156`	`156`	`}`
	`157`	`+`
	`158`	+ // No `dispose` method, because there's nothing for it to do.
	`159`	`+ // The [MentionAutocompleteView]s are owned by (i.e., they get [dispose]d by)`
	`160`	`+ // the UI code that manages the autocomplete interaction, including in the`
	`161`	`+ // case where the [PerAccountStore] is replaced. Discussion:`
	`162`	`+ // https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.60MentionAutocompleteView.2Edispose.60/near/1791292`
	`163`	`+ // void dispose() { … }`
`157`	`164`	`}`
`158`	`165`
`159`	`166`	`/// A view-model for a mention-autocomplete interaction.`