Skip to content

Inbox collapse can trigger 1s hang #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue Nov 20, 2024 · 0 comments
Open

Inbox collapse can trigger 1s hang #1066

gnprice opened this issue Nov 20, 2024 · 0 comments
Labels
a-home The home screens of the app; finding and starting conversations beta feedback Things beta users have specifically asked for performance Smooth and responsive UI; fixing jank, stutters, and lag

Comments

@gnprice
Copy link
Member

gnprice commented Nov 20, 2024

See report in chat: https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/inbox.20view.20performance/near/1984835

I have a channel that gets all my GitHub notifications, and thus has like 5000 topics with unread messages. The inbox view mostly works fine with it, but a thing I've noticed is that when I click the toggle to collapse the channel's 40K unreads, the collapse animates instantly but then immediately after there's like a 1-second lag where the app feels frozen. After that it works happily.

We don't have a diagnosis for this. Initially I thought it might be #1065; but the slow computation in that issue has to be completed in order to even tell the collapse animation to begin, and the lag here comes after the collapse has finished.

I wasn't able to reproduce this. I tried a test user that's subscribed to basically the set of default channels on chat.zulip.org, and where I marked the last year or so of history as unread (well over the 50k limit of what the server will tell the client anyway). It's possible that the key to a repro is to match the reported pattern where one channel has an enormous number of distinct unread conversations.

It's possible this is a symptom of #389; not sure.

@gnprice gnprice added a-home The home screens of the app; finding and starting conversations performance Smooth and responsive UI; fixing jank, stutters, and lag beta feedback Things beta users have specifically asked for labels Nov 20, 2024
@gnprice gnprice added this to the Post-launch milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-home The home screens of the app; finding and starting conversations beta feedback Things beta users have specifically asked for performance Smooth and responsive UI; fixing jank, stutters, and lag
Projects
Status: No status
Development

No branches or pull requests

1 participant