Skip to content

Experiment with RTL layout #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Apr 20, 2023 · 1 comment
Closed

Experiment with RTL layout #77

gnprice opened this issue Apr 20, 2023 · 1 comment
Labels
a-design Visual and UX design a-i18n Translation, localization, internationalization

Comments

@gnprice
Copy link
Member

gnprice commented Apr 20, 2023

Flutter's API is designed to thoroughly support working in a right-to-left layout direction, as well as left-to-right. It'd be neat to experiment with that; see how much works immediately out of the box; and then see how hard it is to fix up any places where we've introduced an assumption of a left-to-right layout.

This would be a feature that no existing Zulip client supports. If you try switching the Zulip web app to Arabic, for example, basically none of the layout changes — it's all still laid out for LTR.

I think the basic way to test this will look like:

  • Where we construct a MaterialApp in lib/widgets/app.dart, add a supportedLocales argument that says we support some RTL locale, like Persian or Arabic or Hebrew. (By default it doesn't assume we support anything but en_US.)
  • Then in your device's system settings, set that as your preferred locale.
  • See how the app responds.
@gnprice
Copy link
Member Author

gnprice commented May 25, 2024

@naderm11 has kindly done this experiment, and reports that it works well out of the box. So, closing this issue as complete.

If in the future we find areas where our layout doesn't behave properly in RTL, we can open specific issues for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-design Visual and UX design a-i18n Translation, localization, internationalization
Projects
Status: Done
Development

No branches or pull requests

1 participant