Skip to content

Handle flags for @-topic mentions #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue Aug 19, 2024 · 0 comments
Open

Handle flags for @-topic mentions #894

gnprice opened this issue Aug 19, 2024 · 0 comments
Labels
a-api Implementing specific parts of the Zulip server API server-8 Things new in Zulip Server 8.0

Comments

@gnprice
Copy link
Member

gnprice commented Aug 19, 2024

We should handle the topic_wildcard_mentioned per-user flag on messages:
https://zulip.com/api/update-message-flags#available-flags
https://chat.zulip.org/#narrow/stream/378-api-design/topic/highlight.20topic-wildcard.20mention/near/1621613

As part of the same PR, we should handle the also-new stream_wildcard_mentioned flag, and then make our handling of the now-deprecated wildcard_mentioned flag occur only as a fallback on servers that don't support the new flags. (In particular this means there should be // TODO(server-8) comments for us to delete the wildcard_mentioned code, leaving only the code for the new pair of flags.)

I believe the behavior we'll currently want is the same on either of the new flags as it is on the old flag. The one way I'm aware of that we'll eventually use the distinction is for #647, which is in the future and out of scope for this issue.

@gnprice gnprice added the a-api Implementing specific parts of the Zulip server API label Aug 19, 2024
@gnprice gnprice added this to the Launch milestone Aug 19, 2024
@gnprice gnprice added the server-8 Things new in Zulip Server 8.0 label Aug 19, 2024
@gnprice gnprice modified the milestones: M5: Launch, M6: Post-launch Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API server-8 Things new in Zulip Server 8.0
Projects
Status: No status
Development

No branches or pull requests

1 participant