Add support for executable descriptions #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dd64199 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
Jul 24, 2025
| } | ||
| } | ||
| "Time machine details." |
There was a problem hiding this comment.
Interestingly this seems to add newlines at the front and end when parsed
kitten
reviewed
Jul 24, 2025
| do { | ||
| let _description: ast.StringValueNode | undefined; | ||
| if (input.charCodeAt(idx) === 34 /*'"'*/) { | ||
| _description = value(true) as ast.StringValueNode; |
There was a problem hiding this comment.
Would we want to add an invariant for checking that this can only be a string or split the string out?
JoviDeCroock
force-pushed
the
support-executable-descriptions
branch
2 times, most recently
from
41fffb8 to
c802ab1
Compare
JoviDeCroock
force-pushed
the
support-executable-descriptions
branch
from
c802ab1 to
dd64199
Compare
kitten
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds built-in support for graphql/graphql-spec#1170
Supports descriptions on