This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Update dependencies #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Running
make setup
fails because some composer dependencies conflict with PHP 8.1 fromcomposer:latest
image.Also, running
make install-npm
fails with the current LTS node 16.15.1 on M1 Mac (arm64).Alternate Designs
Not sure that dropping Node to 14 is necessary, need someone to check if it runs successfully on Intel Macs.
Verification Process
Run every meaningful make scripts, should be able to run. Some test scripts are known to fail, but this is expected.
make setup
- OKmake start
- wp-env started at port 8888make build
- created POT file and min.jsmake test-lint-php
- Runs but produce linting errors (expected)make test-lint-javascript
- OKmake test-unit
- Runs but produce errors and failures (expected)make test-e2e
- Runs but produce errorsmake release
- Created zip fileChecklist:
Changelog Entry
Credits
Props @