Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Update dependencies #1

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Update dependencies #1

merged 5 commits into from
Jun 28, 2022

Conversation

cadic
Copy link

@cadic cadic commented Jun 27, 2022

Description of the Change

Running make setup fails because some composer dependencies conflict with PHP 8.1 from composer:latest image.

Also, running make install-npm fails with the current LTS node 16.15.1 on M1 Mac (arm64).

  1. Updated composer dependencies in composer.lock and allowed plugins in composer.json to be compatible with the latest composer docker image
  2. Dropped Node docker image to version 14

Alternate Designs

Not sure that dropping Node to 14 is necessary, need someone to check if it runs successfully on Intel Macs.

Verification Process

Run every meaningful make scripts, should be able to run. Some test scripts are known to fail, but this is expected.

  • make setup - OK
  • make start - wp-env started at port 8888
  • make build - created POT file and min.js
  • make test-lint-php - Runs but produce linting errors (expected)
  • make test-lint-javascript - OK
  • make test-unit - Runs but produce errors and failures (expected)
  • make test-e2e - Runs but produce errors
  • make release - Created zip file

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@cadic cadic requested a review from dkotter June 27, 2022 10:34
@cadic cadic self-assigned this Jun 27, 2022
@jeffpaul
Copy link
Member

@dkotter I don't think this will need to route through QA or WPE Code Review, so if you're 👍🏼 on this then I think we're good to just merge this into the feature branch.

@dkotter
Copy link

dkotter commented Jun 27, 2022

@cadic Took a bit just to get the make commands working for me (I ended up having to install a newer version of Docker Desktop and they finally started to run).

I have an Intel Mac and build commands worked fine for me both with node set to v14 and set to LTS. So not sure we need to change that to v14 but I'll defer to you on that. Everything else worked great.

@cadic cadic merged commit f84f82b into feat/phpcompat-revamp Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants