Use table.clone instead of an empty table when reading structs #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Axen
requested changes
Jul 6, 2025
compiler/codegen/init.luau
Outdated
|
|
||
| builder:append(BUFFER_TEMPLATE) | ||
|
|
||
| builder:append("-- upvalues start\n") |
There was a problem hiding this comment.
Suggested change
| builder:append("-- upvalues start\n") | |
| builder:append_line("-- upvalues start") |
compiler/codegen/init.luau
Outdated
| for upval_id, default in lirr.upvalues do | ||
| gen_upvalue(context, upval_id, default) | ||
| end | ||
| builder:append("-- upvalues end\n") |
There was a problem hiding this comment.
Suggested change
| builder:append("-- upvalues end\n") | |
| builder:append_line("-- upvalues end") |
compiler/lir/types.luau
Outdated
Comment on lines
109
to
117
| export type ProjShapedTable<T> = { | ||
| write __phantom_type: T, | ||
|
|
||
| type: "projection", | ||
| kind: "shaped_table", | ||
| base: LValue<T>, | ||
| shape: { string }, | ||
| } | ||
|
|
Comment on lines
+213
to
+218
| local function add_upvalue<T>(self: Builder, upvalue_name: string, upvalue_default: RValue<T>) | ||
| local upval = upvalue(upvalue_name) | ||
| self.ctx.lir.upvalues[upval] = upvalue_default | ||
|
|
||
| return upval | ||
| end |
There was a problem hiding this comment.
Would be good to have a panic here for duplicate upvalues entries
Comment on lines
+93
to
+100
| local ty = hir.ty_from_id(ctx.hir, decl.ty_id) | ||
|
|
||
| if ty.kind == "struct" then | ||
| local template = create_struct_template(decl.ty_id, ty) | ||
|
|
||
| ctx.lir.upvalues[builders.fn.upvalue(tostring(decl.ty_id))] = template | ||
| end | ||
|
|
There was a problem hiding this comment.
Would need to build these in a different place (builders/ty possibly?) or we'd have to copy this segment for events and functs too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an optimization where a shaped table is cloned, instead of an empty completely dynamic table.
This also required the implementation of upvalues into codegen & LIR