Criteria Class Validation #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooks like an external URL.
* feature/evidence-class: Add test to ensure node-level validation runs even when the node ID looks like an external URL. Resolves #49: Evidence class internal property checks.
…a task discovery in BadgeClass ClassValidators.
…id of unnecessary code duplication. Expand tests on optional and many properties for primitive and ID properties. Add additional tests for criteria validation.
Merged
ViktorHaag
reviewed
Apr 7, 2017
| @@ -211,7 +252,7 @@ def __init__(self, class_name): | |||
| # 'expected_class': OBClasses.VerificationObject, 'required': True}, | |||
| {'prop_name': 'issuedOn', 'prop_type': ValueTypes.DATETIME, 'required': True}, | |||
| {'prop_name': 'expires', 'prop_type': ValueTypes.DATETIME, 'required': False}, | |||
| {'prop_name': 'image', 'prop_type': ValueTypes.URL, 'required': False}, # TODO: ValueTypes.DATA_URI_OR_URL | |||
There was a problem hiding this comment.
There may eventually be a merge conflict here, as in my recent PR #77 I switched this TODO to a test against ValueTypes.DATA_URI_OR_URL.
There was a problem hiding this comment.
No, trouble -- I'll do a manual merge when approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency #72 -- resolve that PR first to get a cleaner diff here, as this includes a couple of its commits to avoid more difficult parallel merge.
Adds
CRITERIA_PROPERTY_DEPENDENCIEStask to check that at least 1 of:idnarrativeexists for a BadgeClass's criteria.