Skip to content

Add Hz counter to Classic modes #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Not-A-Normal-Robot
Copy link
Member

also tidied up 1 line of code

@MrZ626
Copy link
Collaborator

MrZ626 commented Aug 29, 2022

tips: using local xxx={...} will use lots of memory, I recommend to replace if ... then color={r,g,b} with if ... then setColor(r,g,b), it looks longer but can runs faster (and without "memory leak")

@Not-A-Normal-Robot
Copy link
Member Author

wow thanks lol

I should change this when I can

drafting this PR for now so you don't accidentally merge it

@Not-A-Normal-Robot Not-A-Normal-Robot marked this pull request as draft August 31, 2022 19:03
@Not-A-Normal-Robot Not-A-Normal-Robot marked this pull request as ready for review September 29, 2022 05:53
@Not-A-Normal-Robot
Copy link
Member Author

PR is ready to be merged btw

@MrZ626
Copy link
Collaborator

MrZ626 commented Oct 25, 2022

wait, you added more hooks

@Not-A-Normal-Robot
Copy link
Member Author

yeah to make the code faster and simpler

@Not-A-Normal-Robot
Copy link
Member Author

also how do you add hooks properly? the way I did it failed and I had to add another failsafe which probably means I did it completely incorrectly

@Not-A-Normal-Robot
Copy link
Member Author

alright i think ill remake this some other day because the current code isn't that good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants