-
Notifications
You must be signed in to change notification settings - Fork 1
Old documentation update #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dragonflyfree
wants to merge
16
commits into
master
Choose a base branch
from
feature/codespaces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided code sample had the two lines each with their own `<?php` opening tags and `?>` closing tags. This is not in the style of the other code examples provided in these tutorials, and if directly copied, results in an error.
All other code samples within the tutorial have the `<?php` opening tag on it's own line followed by a line of white space. Auto-format when saving the document in the codespace also puts the `<?php` on it's own line. To my knowledge, no other code sample in this tutorial uses the PHP close tag, so I removed that. I also changed the codeblock to use PHP syntax highlighting as opposed to HTML highlighting.
Adding whitespace after `<?php` so the code samples on this page match the format of other code samples in the tutorial.
Inconsistent whitespace with spaces and some random tabs here and there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.