Convert DenseGeneral to NNX #1604
Open
+205
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla,
RissyRan,
richjames0,
rni418,
gagika,
shralex,
yangyuwei,
SurbhiJainUSC,
hengtaoguo,
A9isha,
wang2yn84,
wyzhang,
mitalisi,
gpolovets1 and
mailvijayasingh
as code owners
copybara-service
bot
force-pushed
the
test_748311465
branch
3 times, most recently
from
a24f6e9 to
3fcbe6b
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_748311465
branch
7 times, most recently
from
97a92b7 to
da43223
Compare
copybara-service
bot
force-pushed
the
test_748311465
branch
3 times, most recently
from
65a7f45 to
f83299d
Compare
# Description This commit converts `DenseGeneral` to NNX and creates a `dense_general` to interface with it through a Linen wrapper. `dense_general` contains all the same arguments as the Linen version but adds two additional ones: * `input_shape`: the expected shape of the input. * `in_features`: an int or tuple representing the input features. Only one of them can be set at a time. # Tests # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed. PiperOrigin-RevId: 748311465
copybara-service
bot
force-pushed
the
test_748311465
branch
from
f83299d to
f9ca7b2
Compare
bvandermoon
reviewed
May 1, 2025
Comment on lines
+242
to
+257
| module = nnx.bridge.to_linen( | ||
| DenseGeneral, | ||
| in_features=in_features, | ||
| out_features=features, | ||
| axis=axis, | ||
| weight_dtype=weight_dtype, | ||
| dtype=dtype, | ||
| kernel_init=kernel_init, | ||
| kernel_axes=kernel_axes, | ||
| quant=quant, | ||
| use_bias=use_bias, | ||
| matmul_precision=matmul_precision, | ||
| name=name, | ||
| metadata_fn=variable_to_logically_partitioned, | ||
| ) | ||
| return module |
There was a problem hiding this comment.
Just to confirm my understanding - this will not always be a bridge to linen, right? This is just a starting point for the migration and we will eventually have everything just be nnx
This was referenced May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert DenseGeneral to NNX
Description
This commit converts
DenseGeneralto NNX and creates adense_generalto interface with it through a Linen wrapper.dense_generalcontains all the same arguments as the Linen version but adds two additional ones:input_shape: the expected shape of the input.in_features: an int or tuple representing the input features.Only one of them can be set at a time.
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):