[*.py] Resolve pylint w-class: W0102,W0107,W0212,W0221,W0223,W0237,W0404,W0611,W0612,W0621,W0622,W0631,W0707,W0718,W1201,W1203,W1309,W1514,W4901 ; [code_style.sh,.github/workflows/CPUTests.yml] Enable w-class #1749
+146
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelMarks
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla,
RissyRan,
richjames0,
rni418,
gagika,
shralex,
yangyuwei,
SurbhiJainUSC,
hengtaoguo,
A9isha,
wang2yn84,
wyzhang,
mitalisi,
gpolovets1,
mailvijayasingh,
jrplatin,
patemotter,
Lumosis and
aireenmei
as code owners
4 tasks
shralex
requested changes
May 16, 2025
| @@ -633,6 +633,9 @@ def tpu_flash_attention( | |||
| axis_names_q = nn.logical_to_mesh_axes(self.flash_axis_names_q) | |||
| axis_names_kv = nn.logical_to_mesh_axes(self.flash_axis_names_kv) | |||
|
|
|||
| global global_block_q, global_block_kv, global_block_kv_compute, global_block_q_dkv, global_block_kv_dkv | |||
There was a problem hiding this comment.
can you explain the purpose of global here and below
There was a problem hiding this comment.
It was overriding variables that were set globally in the file; shadow variables.
Is it not intended for these to take over the global params? - The wording is confusing so I thought the author just forgot to make them global. I can modify to rename all these variables instead if that's not desired.
| @@ -44,7 +44,8 @@ def test_standalone_dataloader(self): | |||
| ( | |||
| None, | |||
| os.path.join(PKG_DIR, "configs", "base.yml"), | |||
| "run_name=" + random_run_name, | |||
| f"run_name={random_run_name}", | |||
| # pylint: disable=f-string-without-interpolation | |||
There was a problem hiding this comment.
lets instead remove the "f" from the next line, and below too
There was a problem hiding this comment.
@shralex I got in trouble before when I removed the starting f from f"base_output_directory=gs://runner-maxtext-logs". Apparently it's find/replaced internally?
hengtaoguo
reviewed
May 17, 2025
hengtaoguo
reviewed
May 17, 2025
hengtaoguo
reviewed
May 17, 2025
hengtaoguo
approved these changes
May 19, 2025
shralex
approved these changes
May 19, 2025
…ystem ; [c_cdd/schema2tests.c] Separate test out to .h and .c
copybara-service
bot
merged commit a93d7d8
into
AI-Hypercomputer:main
32 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linting is fun?
Tests
N/A
Checklist
Before submitting this PR, please make sure (put X in square brackets):