Skip to content

[MaxText/inference_microbenchmark.py] Ensure correct exit code #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

[MaxText/inference_microbenchmark.py] Ensure correct exit code #1753

merged 1 commit into from
May 21, 2025

Conversation

SamuelMarks
Copy link
Collaborator

Description

Earlier change accidentally made the exit code not EXIT_SUCCESS… this fixes that issue and also enables the output to be used by other tools.

Closes #1742

FIXES: #1742

Tests

N/A

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

bvandermoon
bvandermoon reviewed May 19, 2025
View reviewed changes
Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of the linting failure

@SamuelMarks SamuelMarks force-pushed the inference_microbenchmark-EXIT_CODE branch from 5a9bb21 to b675b24 Compare May 20, 2025 05:32
@SamuelMarks SamuelMarks force-pushed the inference_microbenchmark-EXIT_CODE branch from b675b24 to c6041b6 Compare May 20, 2025 05:32
@copybara-service copybara-service bot merged commit 41228dd into AI-Hypercomputer:main May 21, 2025
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shralex shralex shralex approved these changes

@bvandermoon bvandermoon bvandermoon approved these changes

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@rni418 rni418 Awaiting requested review from rni418

@gagika gagika Awaiting requested review from gagika gagika is a code owner

@yangyuwei yangyuwei Awaiting requested review from yangyuwei yangyuwei is a code owner

@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner

@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

@wang2yn84 wang2yn84 Awaiting requested review from wang2yn84

@wyzhang wyzhang Awaiting requested review from wyzhang

@mitalisi mitalisi Awaiting requested review from mitalisi

@gpolovets1 gpolovets1 Awaiting requested review from gpolovets1

@mailvijayasingh mailvijayasingh Awaiting requested review from mailvijayasingh

@jrplatin jrplatin Awaiting requested review from jrplatin

@patemotter patemotter Awaiting requested review from patemotter

@Lumosis Lumosis Awaiting requested review from Lumosis

@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inference_microbenchmark.py always exit with 1
3 participants
@SamuelMarks @shralex @bvandermoon