Skip to content

Workaround for '$ref' property name. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2015
Merged

Workaround for '$ref' property name. #4

merged 1 commit into from
Mar 12, 2015

Conversation

IvanGoncharov
Copy link
Contributor

Property could have '$ref' name it's valid name.
Moreover such swagger files exist in the wild see swagger for Google Discovery service.
It would be common problem for any API which return json-schema.
I implement workaround it solve problem but in the same time allowing incorrect references.
I understand that for proper reference detection you need to re-implement half of your library.
In any case it should be addressed in FAQ

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.6% when pulling e33cbb1 on APIs-guru:master into 9ce9dd4 on BigstickCarpet:master.

@JamesMessinger
Copy link
Member

Awesome! I love it when people submit pull requests when they open issues. You rock.

I'll take a closer look at this later today and get it merged in. Thanks!

JamesMessinger added a commit that referenced this pull request Mar 12, 2015
Workaround for '$ref' property name.
@JamesMessinger JamesMessinger merged commit b6b684e into APIDevTools:master Mar 12, 2015
@JamesMessinger
Copy link
Member

@IvanGoncharov, I added some new unit tests specifically for this. Thanks again for reporting the bug.

I also added all 108 of your Swagger files to the test suite, which uncovered a few other bugs. All of those bugs are fixed now as well.

@IvanGoncharov
Copy link
Contributor Author

Thank you very much. I didn't expect such quick fix.
I'm very happy that our collection helping other people with their projects.
We will further expand our API collection.
Till the end of March we plan to add Instagram, Github, Stripe, Twitter and many others.
Also API Evangelist promise us to contribute 700+ additional APIs.
If you have Swagger files for any public API(free or paid, including API for devices), please feel free to make pull request.

@JamesMessinger
Copy link
Member

I'll keep an eye on your repo and add any new APIs to my unit test suite. Thanks for creating that repo. It's super helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants