Skip to content

Conversation

acabarbaye
Copy link
Contributor

Description

logrus being deprecated, the zap logger is introduced to replace it.

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

joshjennings98
joshjennings98 previously approved these changes Mar 15, 2023
Copy link
Contributor

@joshjennings98 joshjennings98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a nitpick about the switch statement

Copy link
Contributor

@joshjennings98 joshjennings98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@acabarbaye acabarbaye merged commit 570052e into master Mar 16, 2023
@acabarbaye acabarbaye deleted the zaplogger branch March 16, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants