-
Notifications
You must be signed in to change notification settings - Fork 1k
Add target GR-PEACH #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target GR-PEACH #132
Conversation
It branches in processing for Cortex-A by macro TARGET_MCU_CORTEX_A. A "swd_host.c" for Cortex-A is created as "swd_host_ca.c". The binary inspection was made comparison in 3 bytes of head of the data because there was no NVIC in Cortex-A. Comparative data can be set for each board by macro BINARY_DETECTION.
Our Flash will take more than 20 seconds to chip erase. Therefore, we have added the process of writing a program with partial erase. Selective erase becomes effective by macro FLASH_PARTIAL_ERASE.
A flash of rza1h is outside the chip, and the flash and port may be different from every board. So it was made the following path. "/source/target/renesas/rza1h/gr-peach/"
Hi @d-kato thanks for the PR. Would it be possible to move the partial erase into a second PR to make testing and merging easier? |
#ifdef FLASH_PARTIAL_ERASE | ||
// Processing for low-speed devices of chip erasure. | ||
flash_manager_printf(" skip intf->erase_chip\r\n"); | ||
#else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FLASH_PARTIAL_ERASE is a very useful feature. This would be nice as a run-time configurable value. Maybe a function to set the mode?
flash_manager_init(const flash_intf_t *flash_intf, flash_mode_t)
or maybe a seperate function
flash_manager_mode(CHIP_ERASE) / flash_manager_mode(SECTOR_ERASE)
What do you think @d-kato?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "flash_manager_init()" is preferred.
In the case of "flash_manager_mode()", it might appear to be able to change at any time.
Fixed the following. https://github.com/mbedmicro/DAPLink/pull/132/files/b6a53f244ca2fb9e9d523945db955b2511fa0e1b#r74541708 https://github.com/mbedmicro/DAPLink/pull/132/files/b6a53f244ca2fb9e9d523945db955b2511fa0e1b#r74541791 https://github.com/mbedmicro/DAPLink/pull/132/files/b6a53f244ca2fb9e9d523945db955b2511fa0e1b#r74542380
Hi @c1728p9 , |
Hi @d-kato unfortunately, I haven't had time to test this so it won't make it into 0242. I'll try to get to this by the next release. I very much want Cortex A / Peach support in DAPLink so thanks for the PR. |
I close this PR for rebase. |
It branches in processing for Cortex-A by macro TARGET_MCU_CORTEX_A.
A "swd_host.c" for Cortex-A is created as "swd_host_ca.c".
The binary inspection was made comparison in 3 bytes of head of the data because there was no NVIC in Cortex-A.
Comparative data can be set for each board by macro BINARY_DETECTION.
Our Flash will take more than 20 seconds to chip erase.
Therefore, we have added the process of writing a program with partial erase.
Selective erase becomes effective by macro FLASH_PARTIAL_ERASE.
A flash of rza1h is outside the chip, and the flash and port may be different from every board.
So it was made the following path.
"/source/target/renesas/rza1h/gr-peach/"