build script improvements #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revent script from closing console window.
|
test this please |
tools/build_release_uvision.bat
Outdated
| python tools/copy_release_files.py | ||
| if %errorlevel% neq 0 exit %errorlevel% | ||
| exit %level% | ||
| exit /B %level% |
There was a problem hiding this comment.
Nitpick - no newline at end of file
(don't feel like you need to fix this, just thought I would mention it)
There was a problem hiding this comment.
Good nitpick. Newline addition pushed
|
PR looks good. Thanks for the fixes |
gerargz
added a commit
to microbit-foundation/DAPLink
that referenced
this pull request
Jan 6, 2021
…ted to return LED to its default state and clear pending I2C interrupts
mbrossard
pushed a commit
to mbrossard/DAPLink
that referenced
this pull request
Aug 5, 2021
…ted to return LED to its default state and clear pending I2C interrupts
c1728p9
pushed a commit
to c1728p9/DAPLink
that referenced
this pull request
Aug 14, 2021
…ted to return LED to its default state and clear pending I2C interrupts
mathias-arm
pushed a commit
to mathias-arm/DAPLink
that referenced
this pull request
Aug 20, 2021
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
…ted to return LED to its default state and clear pending I2C interrupts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear output dir at outset to ensure all resulting artifacts are new
Use /B in exit command otherwise the script closes the console window when it completes. The previous behavior proved to be quite the pain. I'd run the script, and eventually the console would close, leaving me unable to see if the build failed or succeeded.