Added support for Embedded Artists LPC4088 boards #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPC4088 Display Module (LPC4088DM) LPC4088 QuickStart Board (LPC4088QSB)
source/board/lpc4088dm.c
Outdated
| * limitations under the License. | ||
| */ | ||
|
|
||
| const char *board_id = "1065"; |
There was a problem hiding this comment.
This board ID isn't in the database. Is this a new board?
There was a problem hiding this comment.
I just sent you an email with an explanation of it.
There was a problem hiding this comment.
Thanks. I'll see about getting this added to the database.
Changes: - Changed board id for lpc4088dm to 1062 - Removed BOARD_* defines - Splitted target.c into two separate files to avoid ifdef - Moved most of target specific code from gpio.c to target_reset.c - Changed default FS size from 8 to 68 MB - Added GPIO_RESET_IN_NOT_SUPPORTED define for boards not supporting RESET input signal
|
Replaced my own file system changes with pull request #112 and tested it. Tested successfully. |
|
|
||
| // Must be bigger than 4x the flash size of the biggest supported | ||
| // device. This is to accomidate for hex file programming. | ||
| // device. This is to accomodate for hex file programming. |
There was a problem hiding this comment.
Nitpick - should be "accommodate"
|
Replaced by pull request #121 to get a cleaner commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
LPC4088 Display Module (LPC4088DM)
LPC4088 QuickStart Board (LPC4088QSB)
Both boards have QSPI flash (16MB and 8MB respectively) so the file system had to be increased. The comment said that 4x max size was needed and with 16MB QSPI + 512KB internal flash that means ca 68MB file system. The OVERRIDE_FS_MB_SIZE flag (if set) controls the size of the file system.