Fix invalid SocketAddress returned from recvfrom #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined in both NetworkInterface and NetworkStack: - gethostbyname - add_dns_server
In the current version of the firmware, the esp8266 handles UDP in an odd way. Rather than packet based transactions, the esp8266 handles UDP like a connection based protocol. To return the correct address, the esp8266 just saves the last connection established by UDP. Additionally this patch added the ability of a socket to change connection addresses. Note: This firmware is still unable to recieve connections from arbitrary hosts.
geky
force-pushed
the
fix-recvfrom-address
branch
from
86d8500 to
cd1bf66
Compare
c1728p9
approved these changes
Dec 2, 2016
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of the firmware, the esp8266 handles UDP in an odd way. Rather than packet based transactions, the esp8266 handles UDP like a connection based protocol.
To return the correct address, the esp8266 just saves the last connection established by UDP. Additionally this patch added the ability of a socket to change connection addresses.
Note: This firmware is still unable to recieve connections from arbitrary hosts.
related issue #15
cc @jankii01