readme: Remove quotes from ssid/pass defines #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In windows, apparently quotes are just copied into the definition of #defines passed on the command line.
|
Indeed I've been testing this on Windows and this PR solves the problem. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In windows, apparently quotes are just copied into the definition of #defines passed on the command line. The quotes were originally to help users pass in non-alphabetic characters, but if it's going to cause problems on windows they should be omitted. Users on Linux or Mac can add the quotes themselves when needed.
Note: this is not an issue when using the config system or editting the file manually.
Need to check with @MarceloSalazar that this resolves the problem he was seeing.