mbed-cli add fails to interpret PKA URL correctly

[bremoran]

The following command results in a request for a username password pair. This is a standard URL for SSH Public Key Authentication to git.

mbed add git@github.com:ARMmbed/<somerepo>.git

[screamerbg]

Import/clone will fail for anonymous users without registered PKA keys in github. We do expect that the majority of users won't not have either github account or registered PKA. Also all mbed OS repositories will be public, so 2fa won't be needed for the public repos.

E.g.

$ mv ~/.ssh ~/.ssh-unset
$ git clone git@github.com:ARMmbed/mbedtls.git
Cloning into 'mbedtls'...
The authenticity of host 'github.com (192.30.253.113)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'github.com,192.30.253.113' (RSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

mbed TLS is a public repo

[bremoran]

Please reopen this ticket. It is not resolved by your comment. The documentation of mbed add says:

--protocol [PROTOCOL]
                        Transport protocol for the source control management.
                        Supported: https, http, ssh, git. Default: inferred
                        from URL.

This is the standard format for a SSH url in git: git@github.com:ARMmbed/<somerepo>.git

mbed add is NOT inferring the protocol correctly from the URL.

[screamerbg]

@bremoran can you try mbed add git@github.com:ARMmbed/<somerepo>.git --protocol ssh?

[bremoran]

Yes, that works fine.

When I ask github for the clone URL of the mbed-os repo with https, for example, it gives me this:
https://github.com/ARMmbed/mbed-os.git
With ssh, I get this:
git@github.com:ARMmbed/mbed-os.git

When I clone each of those with git, it handles them correctly without additional parameters.

[screamerbg]

I see what you mean. The protocol is not inferred from the URL is what you mean. Right?

[bremoran]

That is correct.

[screamerbg]

Now implemented in mbed CLI 0.8.1