Skip to content

Add pkgconfig files #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add pkgconfig files #190

wants to merge 2 commits into from

Conversation

tiennou
Copy link

@tiennou tiennou commented Jul 29, 2019

This adds support for automatically generating pkgconfig files for the mbedcrypto library.

Exctracted from Mbed-TLS/mbedtls#1753.

@Patater
Copy link
Contributor

Patater commented Jul 30, 2019

This currently breaks the test_cmake_as_subdirectory test in all.sh. Could you please fix?

Thanks!

@Patater Patater added enhancement New feature or request needs: review The pull request is ready for review. This generally means that it has no known issues. labels Jul 30, 2019
@Patater Patater self-requested a review July 30, 2019 12:32
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs work to pass ./tests/scripts/all.sh testing.

@Patater Patater added the needs: work The pull request needs rework before it can be merged. label Sep 4, 2019
@piotr-now
Copy link
Contributor

piotr-now commented Dec 16, 2019

Needs work to pass ./tests/scripts/all.sh testing.

./tests/scripts/all.sh requires a lot of binaries which have to be installed manually. You can also run this tests by running ./tests/scripts/all-in-docker.sh. All required packages should be installed automatically in case of second script

@tiennou
Copy link
Author

tiennou commented Dec 17, 2019

all/scripts/all-in-docker.ssh reported the following :

[snip]
 ---> a8ddfff48cff
Step 26/26 : RUN pip3 install --no-cache-dir     mbed-host-tests     mock
 ---> Using cache
 ---> 6b81a40296b7
Successfully built 6b81a40296b7
Successfully tagged armmbed/mbedtls-test:bionic
fatal: not a git repository: /Users/tiennou/Projects/mbedtls/crypto/../.git/modules/crypto
Warning - the configuration file 'include/mbedtls/config.h' has been edited. 
You can either delete or preserve your work, or force the test by rerunning the
script as: tests/scripts/all.sh --force

Not sure how to proceed, I've asked for --force but now it's making my CPU run hot 😉. My working copy is clean, it just predates the mbedcrypto split, so maybe something went wrong with the submodule ? I haven't seen git report any issue with it though…

EDIT: The following works : git --git-dir=/Users/tiennou/Projects/mbedtls/crypto/../.git/modules/crypto ls-files and reports the list of files in HEAD, so the repo is fine.

EDIT EDIT: I've made a real clone of my submodule, and it works 🤷‍♂.

@yanesca yanesca removed the needs: work The pull request needs rework before it can be merged. label Feb 5, 2020
@gilles-peskine-arm
Copy link
Collaborator

Mbed Crypto has been merged back into Mbed TLS. Due to the nature of this pull request, it does not make sense to apply it to Mbed Crypto separately. Please make further updates on the corresponding Mbed TLS pull request: Mbed-TLS/mbedtls#1753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs: review The pull request is ready for review. This generally means that it has no known issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants