Avoid overwriting tls headers in submodule mode #344
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Summary of change (What the change is for and why)
When crypto is embedded as a submodule and the cmake build system is used, it would previously overwrite some header files installed by tls.
Most of them are harmless (since they should be identical), but config.h is a special case.
tls's and crypto's config.h files differ widely in scope and overwriting the more general, bigger config.h file from tls with crypto's smaller one will make a lot of features unavailable in programs using tls.
Let's just avoid overwriting any tls header in submodule mode.
Note that this will not fix the potential issue that crypto might be using a different configuration than tls in the submodule case.
Documentation (Details of any document updates required)
N/A
Pull request type (required)
Test results (required)
Reviewers (optional)
TBD
Release Notes (required for feature/major PRs)
Summary of changes
N/A
Impact of changes
N/A
Migration actions required
N/A