Retarget - main - invoke serial init #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some toolchains might not call open() for stdio handle prior main, which breaks usage:
```
void app_start(int, char**)
{
Serial pc(tx, rx);
pc.baud(115200);
printf("sss \n"); //open stdio might happen here
}
```
|
Looks good. And you're right, static initializers can mess with this, but I think this was a problem in the previous code too, so I'll not attempt to fix this here. +1. |
|
+1 |
|
I tried to restart jenkins, it timeouts for our frdm-k64f anyway , should not be the case. I'll report this to jenkins team. |
0xc0170
added a commit
that referenced
this pull request
Jan 14, 2016
Retarget - main - invoke serial init
|
what have you done!?! 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some toolchains might not call open() for stdio handles prior main, which breaks usage:
An example above was not working for our gcc targets.
A note: YOTTA_CFG_MBED_OS_STDIO_DEFAULT_BAUD in this case is the one which is set, no matter what SerialBase ctor sets (if Serial() object (for USBTX,USBRX) is in a global scope, sets baudrate within ctor to different value than YOTTA_CFG_MBED_OS_STDIO_DEFAULT_BAUD), still get overwritten by YOTTA_CFG_MBED_OS_STDIO_DEFAULT_BAUD. Just stating this for a future reference
@bogdanm @pan-