Fixes to FunctionPointer and friends #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 8, 2015 15:00
- Added the 'clear' method on FunctionPointerBase and FunctionPointerBind (needed by MINAR) - Added the function call operator in FunctionPointerBind (also needed by MINAR) - Restructured inheritance schema: since it is useful for FunctionPointerX and FunctionPointerBind to inherit various methods from FunctionPointerBase (like clear() and operator bool()), make them inherit publicly from FunctionPointerBase. The API user still can't instantiate a FunctionPointerBase directly, which is the correct behaviour.
"warning: deleting object of polymorphic class type 'mbed::FunctionPointer0<void>'which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]"
|
Still not convinced about this clear function, but I don't think we can remove the need for it without massive changes to MINAR. With that in mind, +1 |
bogdanm
added a commit
that referenced
this pull request
Jun 10, 2015
Fixes to FunctionPointer and friends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to inherit various methods from FunctionPointerBase (like clear() and operator bool()),
make them inherit publicly from FunctionPointerBase. The API user still can't instantiate a
FunctionPointerBase directly, which is the correct behaviour.