Skip to content

Added comparison operator to FunctionPointerBase. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added comparison operator to FunctionPointerBase. #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mbed/FunctionPointerBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ class FunctionPointerBase {
return (_membercaller != NULL) && (_object != NULL);
}

bool operator==(const FunctionPointerBase& other)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this a const function:

bool operator==(const FunctionPointerBase & other) const

{
return (_membercaller == other._membercaller) && (_object == other._object);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really work properly? membercaller ends up taking the address of a static function, which is the same for all instances of FunctionPointerX<T> for a given T. So, for a given instance inst of type T, wouldn't this return true for 2 function pointers that reffer to different methods of T? Sorry if I'm missing something.

}

/**
* Clears the current function pointer assignment
* After clear(), this instance will point to nothing (NULL)
Expand Down