Choose target dependency only for legacy targets. #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect that build has failed here because of a dependency on the updated legacy targets. Is that correct? |
|
Yes, the build should be restarted once the targets have been updated. Then it should build fine. |
|
Doing a |
With target inheritance, the target dependencies in this module will fall away. However, since we cannot yet filter target dependencies on multiple properties, we need to add a specific `similarTo` tag to the legacy targets. This will allow future targets using target inheritance to not include the `mbed-hal-<chip>` module anymore.
|
-1 until builds pass. |
|
Jenkins restarted, build 42 is green |
|
+1 |
0xc0170
added a commit
that referenced
this pull request
Feb 10, 2016
Choose target dependency only for legacy targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With target inheritance, the target dependencies in this module will fall away.
However, since we cannot yet filter target dependencies on multiple properties, we need to add a specific
similarTotag to the legacy targets.This change is dependent on:
@autopulated Is this a breaking change? User upgrading only their stm32 targets will be fine, but when upgrading only their module, they will receive errors. Is there another way?
@bogdanm @0xc0170 @bremoran @mjs-arm