-
Notifications
You must be signed in to change notification settings - Fork 89
Add support for XPLAINED PRO SAML21 board #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f2c2f0
to
7cb39f6
Compare
@janjongboom You have a merge conflict here. Let me see if it's easy to resolve. |
@janjongboom It looks like the merge conflict is non-trivia. Do you have time to resolve it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work adding a new debugger!
Do you have a windows machine that you can try this on? I notice you had to modify the volume name matching for Mac, you may have to do something similar for the vendor string array on Windows:
mbed-ls/mbed_lstools/windows.py
Line 41 in 281c44a
MBED_STORAGE_DEVICE_VENDOR_STRINGS = ['ven_mbed', 'ven_segger', 'ven_arm_v2m', 'ven_nxp'] |
Finally, it'd be really great if you could add the files from the device to the test/test_data
folder (https://github.com/ARMmbed/mbed-ls/tree/master/test/test_data), especially since this is a new debugger. We would love a new test case as well in https://github.com/ARMmbed/mbed-ls/blob/master/test/platform_detection.py if you have the chance!
@janjongboom great work! Will it work and it is tested on Linux as well? I can support with some testing/debugging on Linux if needed. |
@martinichka It should but haven't verified it. Will (hopefully) do it when back in Netherlands later this week. |
7cb39f6
to
8fbab1c
Compare
Tested on macOS 10.13, Ubuntu 16.04 and Windows 7, all works. Have rebased against master. |
@bridadan Not sure how to add test data for this board, as I'm not using the content but rather the USB ID from the device. |
@janjongboom I'm taking this in good faith for now. I would like to get one of these boards and scrape that testing data. |
Thanks again for doing all of this work! You did all of the hard parts 😄
That's a good point! Though as a matter of good practice and to help us in the future, I'm hoping to collect the files present on at least one platform of each type of debugger interface. This is so we don't have to go track down the board each time we want to test to make sure we didn't break anything. Instead we can just simulate the device in its entirety. This is really helpful when we're trying to improve the detection algorithm. So if you could just copy and paste the contents of the "drive" that shows up when you plug in the board into the |
@bridadan OK, will do (but in 2 weeks because I didn't bring the board :-)). |
Prerequisite for landing ARMmbed/mbed-os#7276. Adding support for Atmel XPLAINED Pro development board. Atmel now uses something similar as DAPLink for programming. Note that the interface chip might need to be updated to latest version to support drag-n-drop programming (and thus mbed-ls), you're prompted to do this when opening Atmel Studio and connecting to the board the first time.
@theotherjimmy