CriticalSection Class Update (MERGE version - mbed-os-5.8) #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| CriticalSectionLock class is based on RAII approach. In other words, the constructor acquires the lock, and the destructor destroys it automatically when it is out of scope. We do not recommend you use CriticalSectionLock as global or a member of a class because you will enter critical section on object creation, and all interrupts will be disabled. | ||
|
|
||
| Nesting of critical section is supported, and the destructor enables interrupts only when you exit from the last nested critical section. |
There was a problem hiding this comment.
Query: Would it be correct to say "Mbed OS supports nesting of critical section, and the destructor..." for active voice?
Update sentence for active voice based on engineer feedback.
AnotherButler
approved these changes
Jan 2, 2018
0xc0170
approved these changes
Jan 3, 2018
|
@deepikabhavnani Is it OK if I merge this into new_engine for 5.8, as long as I don't merge it into 5.7? Or should I wait? |
|
Yes. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CriticalSection Class was update and new member functions were added. See https://jira.arm.com/browse/IOTMORF-1773 and ARMmbed/mbed-os#5621 for more info.