Skip to content

AStyle update (use options and ignore file for astyle) #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 1, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 7, 2018

Depends on ARMmbed/mbed-os#6014 (once it lands), we got astyle options and ignore paths.

I added documentation to cover the new option file and ignore paths (a mention that 3rd parties libraries should not be formatted).

Any other suggestions for this update? We are adding this check to travis, shall we mention it there that automatic checks are done for all changes?

@adbridge @theotherjimmy @cmonr @kjbracey-arm Please review (@AnotherButler can you add them as reviewers)

@0xc0170 0xc0170 changed the title AStyle update AStyle update (use options and ignore file for astyle) Feb 7, 2018
```

File `.astylerc` defines Mbed OS code style and it's located in Mbed OS root directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible addition here - "Reformat a code should be in a commit with no other changes."

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Change if desired, but not blocking.

@@ -14,6 +14,16 @@ Whether you're writing new code or fixing bugs in existing code, please follow t

Mbed OS follows the [K&R style](https://en.wikipedia.org/wiki/Indent_style#K.26R_style), with at least two exceptions (which can be found in the list below the code sample).

The only exception to this coding style are third-party code. Third-party code should be added to the `.astyleignore` file located in the Mbed OS root directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The only exception to this coding style involves third-party code."

@AnotherButler
Copy link
Contributor

code dependency: ARMmbed/mbed-os#6590

Add requested change from comment.
@AnotherButler AnotherButler merged commit 2009be5 into ARMmbed:5.7 May 1, 2018
@0xc0170
Copy link
Contributor Author

0xc0170 commented May 2, 2018

I've just realized the destination branch was wrong ( 5.7) ? Looking at it, it might be my bad back 2 months ago.

Should this be sent to new engine? I can correct it , and we can revert this on 5.7 if needed

AnotherButler pushed a commit that referenced this pull request May 2, 2018
Make changes from #400 after reviewing on test site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants