AStyle update (use options and ignore file for astyle) #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
changed the title
0xc0170
commented
Feb 7, 2018
| ``` | ||
|
|
||
| File `.astylerc` defines Mbed OS code style and it's located in Mbed OS root directory. | ||
|
|
There was a problem hiding this comment.
One possible addition here - "Reformat a code should be in a commit with no other changes."
AnotherButler
requested review from
adbridge,
kjbracey,
theotherjimmy and
cmonr
adbridge
approved these changes
Feb 8, 2018
cmonr
approved these changes
Feb 8, 2018
| @@ -14,6 +14,16 @@ Whether you're writing new code or fixing bugs in existing code, please follow t | |||
|
|
|||
| Mbed OS follows the [K&R style](https://en.wikipedia.org/wiki/Indent_style#K.26R_style), with at least two exceptions (which can be found in the list below the code sample). | |||
|
|
|||
| The only exception to this coding style are third-party code. Third-party code should be added to the `.astyleignore` file located in the Mbed OS root directory. | |||
There was a problem hiding this comment.
"The only exception to this coding style involves third-party code."
|
code dependency: ARMmbed/mbed-os#6590 |
Add requested change from comment.
AnotherButler
approved these changes
May 1, 2018
|
I've just realized the destination branch was wrong ( 5.7) ? Looking at it, it might be my bad back 2 months ago. Should this be sent to new engine? I can correct it , and we can revert this on 5.7 if needed |
AnotherButler
pushed a commit
that referenced
this pull request
May 2, 2018
Make changes from #400 after reviewing on test site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ARMmbed/mbed-os#6014 (once it lands), we got astyle options and ignore paths.
I added documentation to cover the new option file and ignore paths (a mention that 3rd parties libraries should not be formatted).
Any other suggestions for this update? We are adding this check to travis, shall we mention it there that automatic checks are done for all changes?
@adbridge @theotherjimmy @cmonr @kjbracey-arm Please review (@AnotherButler can you add them as reviewers)