-
Notifications
You must be signed in to change notification settings - Fork 178
AStyle update (use options and ignore file for astyle) #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
``` | ||
|
||
File `.astylerc` defines Mbed OS code style and it's located in Mbed OS root directory. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One possible addition here - "Reformat a code should be in a commit with no other changes."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit. Change if desired, but not blocking.
@@ -14,6 +14,16 @@ Whether you're writing new code or fixing bugs in existing code, please follow t | |||
|
|||
Mbed OS follows the [K&R style](https://en.wikipedia.org/wiki/Indent_style#K.26R_style), with at least two exceptions (which can be found in the list below the code sample). | |||
|
|||
The only exception to this coding style are third-party code. Third-party code should be added to the `.astyleignore` file located in the Mbed OS root directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The only exception to this coding style involves third-party code."
code dependency: ARMmbed/mbed-os#6590 |
Add requested change from comment.
I've just realized the destination branch was wrong ( 5.7) ? Looking at it, it might be my bad back 2 months ago. Should this be sent to new engine? I can correct it , and we can revert this on 5.7 if needed |
Make changes from #400 after reviewing on test site.
Depends on ARMmbed/mbed-os#6014 (once it lands), we got astyle options and ignore paths.
I added documentation to cover the new option file and ignore paths (a mention that 3rd parties libraries should not be formatted).
Any other suggestions for this update? We are adding this check to travis, shall we mention it there that automatic checks are done for all changes?
@adbridge @theotherjimmy @cmonr @kjbracey-arm Please review (@AnotherButler can you add them as reviewers)