Fix PLMN trace for IAR #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAR 8.32 does not support printing null string.
AnttiKauppila
approved these changes
Mar 20, 2019
|
Pedant alert. "Null string" is a slightly fuzzy concept. You're not printing a null string here. A C string is a zero-terminated array of characters. A null string would be an empty one. This is passing an invalid pointer to someone expecting a pointer to a string. C standard requires that |
|
@kivaisan Shouldn't this be targeting the 5.12 branch? |
|
Ok. I'll close this one and I created a new PR to 5.12 branch (#128) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IAR 8.32 does not support printing null string.
This is a fix for #125