Add TLSSocket example #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnotherButler Please review & merge. Will be linked into the ongoing TLSSocket documentation PR |
|
@kjbracey-arm FYI |
kjbracey
reviewed
Nov 9, 2018
TLSSocket/main.cpp
Outdated
| // Bring down the ethernet interface | ||
| net->disconnect(); | ||
| printf("Done\n"); | ||
| } |
TLSSocket/main.cpp
Outdated
| size = strlen(query); | ||
|
|
||
| // Loop until whole request sent | ||
| while(size) { |
There was a problem hiding this comment.
This loop should not be necessary. A blocking socket or file handle is supposed to send everything. (In Unix a signal could interrupt, but not mbed OS).
See ARMmbed/mbed-os#5466 - loop would have been necessary in older OS versions.
Following the logic from that PR, if TLSSocket needs the loop, it should be fixed to match TCPSocket.
Missing space, anyway
| return result; | ||
| } | ||
|
|
||
| TLSSocket *socket = new TLSSocket; |
There was a problem hiding this comment.
As you've configured a big main stack, no particular reason to new this? Or the buffer?
| NetworkInterface *net = NetworkInterface::get_default_instance(); | ||
|
|
||
| if (!net) { | ||
| printf("Error! No network inteface found.\n"); |
kjbracey
reviewed
Nov 12, 2018
AnotherButler
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nearly a verbatim copy of Socket examples, but now uses TLSSocket.