Issues after device.h -> targets.json conversion

[bogdanm]

There are still some device.h files with actual data left in the tree, see for example https://github.com/mbedmicro/mbed/blob/master/hal/targets/hal/TARGET_NORDIC/TARGET_MCU_NRF51822/TARGET_NRF51822_MKIT/device.h. These should have gone away.
Cc @theotherjimmy

[theotherjimmy]

you're right. these should have gone away. I missed the warning:
[WARNING] device NRF51822_MKIT did not have an associated entry in targets.json

[0xc0170]

Please @theotherjimmy send a fix or let us know otherwise

[theotherjimmy]

Working on it. will link this issue with the pr when I get that up.

[theotherjimmy]

so, the reason for the warning is that there is no entry with the string "NRF51822_MKIT" as part of the name or the extra labels of any entry within target.json. should I instead be matching on the MCU_NRF51822 instead?

[theotherjimmy]

#1859

[theotherjimmy]

@bogdanm the PR was merged. is this all cleaned up now?

[theotherjimmy]

@bogdanm @0xc0170 PING! Is this resolved?

[0xc0170]

It should be