-
Notifications
You must be signed in to change notification settings - Fork 3k
[LWIP] - Wrong header inclusion #2993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@0xc0170 What could we do about this ? This might cause compilation errors for every projects using lwip. |
The emac file referenced above should use config file to get device macros (used to be I'll have a look and send a propose a fix. |
what about the duplication of |
Yes, lets create a separate issue. Is not already in the issue tracker - having duplicated header files in the code base ? |
DEVICE_ are passed as command line -D, thus no inclusion is required. ``platform.h`` is C++ header file, should not be pulled in C files
Fixed in #2994 |
DEVICE_ are passed as command line -D, thus no inclusion is required. ``platform.h`` is C++ header file, should not be pulled in C files
Description
The file
emav_lwip.c
include the headerplatform.h
which includesC++
standard headers. Therefore, the compilation fail on GCC because standard C++ headers are not accessible from C files.This bug can be hidden by the duplicate
platform.h
in the code base, depending on the project, the compiler can pick the one inmbedtls
or the one inplatform
.Bug
Target
K64F
Toolchain:
GCC_ARM
Toolchain version:
4.9.3
mbed-cli version:
0.9.5
meed-os sha:
a551faa
The text was updated successfully, but these errors were encountered: