NUMAKER_PFM_NUC472 LWIP implementation contains printf

[bridadan]

Description

• Type: Bug
• Priority: Minor

---

Bug

Target
NUMAKER_PFM_NUC472

meed-os sha:
aa6780d Merge pull request #3416 from bridadan/rename_stm32f1_i2c_api

Notes
The LWIP implementation for the NUMAKER_PFM_NUC472 currently contains calls to printf. These should be removed or repleace with a debug print function that can be enabled conditionally (not sure which option would be preferred here @geky?)

The files in question are here: https://github.com/ARMmbed/mbed-os/blob/master/features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_NUVOTON/TARGET_NUC472/nuc472_eth.c#L102

and here: https://github.com/ARMmbed/mbed-os/blob/master/features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_NUVOTON/TARGET_NUC472/nuc472_netif.c#L499

cc @ccli8

[geky]

Agreed. Perhaps they should be hidden behind an EMAC_DEBUG flag?

[bridadan]

@geky, or maybe just use LWIP_DEBUGF instead of printf? Is that the print macro/function that by default is disabled?

[geky]

@bridadan LWIP_DEBUGF is a good idea, however we are planning on separating the emac implementations from lwip to open up more options with other network stacks. We could use LWIP_DEBUGF as a temporary solution until the emac api (which will probably have its own EMAC_DEBUG flag) becomes standardized.

[bridadan]

@geky So moving forward, maybe replace the current printfs with the LWIP_DEBUGF, then when you do the emac overhaul they can be changed along with the rest of the LWIP_DEBUGF calls?

[ccli8]

cc @cyliangtw

[cyliangtw]

@bridadan
The printf(...) is for log info. Such like, as while you boot linux system, you could also see driver init info including ethernet.
Adopt your suggestion to fix this issue by LWIP_DEBUGF in PR #3434 .

[0xc0170]

Thanks @cyliangtw @ccli8 for looking at this and fixing it. we will review the PR with fixes soon.

[cyliangtw]

@0xc0170
PR #3434 was accepted and merged.
Please help to close it.