remove non empty directory returns inconsistent error codes between LittleFS & FatFS

[itayzafrir]

Attempting to remove/delete a non-empty directory from the FS returns different error codes when using FatFS vs LittleFS

• Type: Bug
• Priority: Major

---

Bug

Target
K64F

Toolchain:
GCC_ARM

Expected behavior
The same error code will be returned for both file systems

Actual behavior
When trying to remove a non-empty directory using FatFS: error code = EACCES
When trying to remove a non-empty directory using LittleFS: error code = EINVAL

Steps to reproduce
remove a non empty directory using FatFS and then using LittleFS

@geky

[geky]

Thanks for reporting this issue. According to Open Group, this should actually be ENOTEMPTY.

[geky]

Ok, I added a patch to #6336 that should take care of this for FAT. LittleFS was updated in #6179 to use ENOTEMPTY.

So this looks like it should be solved soon, let me know if you have any concerns.

[ciarmcom]

ARM Internal Ref: MBOTRIAGE-794

[0xc0170]

Thanks @geky. This should be resolved in 5.9.