fatfs: Update error code mapping #6336

geky · 2018-03-12T18:17:40Z

Description

A lot of the error codes in fatfs were mapped incorrectly. This patch revisits the error code mapping to try to correct these mistakes.

Note: This is required before we can test LittleFS + FAT consistently

ChanFS	was	should be	ChanFS description
FR_OK	0	0	Succeeded
FR_DISK_ERR	EIO	EIO	A hard error occurred in the low level disk I/O layer
FR_INT_ERR	~~EBADF~~	-1	Assertion failed
FR_NOT_READY	EIO	EIO	The physical drive cannot work
FR_NO_FILE	ENOENT	ENOENT	Could not find the file
FR_NO_PATH	~~ENOENT~~	ENOTDIR	Could not find the path
FR_INVALID_NAME	~~ENOENT~~	EINVAL	The path name format is invalid
FR_DENIED	EACCES	EACCES	Access denied due to prohibited access or directory full
FR_EXIST	EEXIST	EEXIST	Access denied due to prohibited access
FR_INVALID_OBJECT	~~EFAULT~~	EBADF	The file/directory object is invalid
FR_WRITE_PROTECTED	EACCES	EACCES	The physical drive is write protected
FR_INVALID_DRIVE	~~ENOENT~~	ENODEV	The logical drive number is invalid
FR_NOT_ENABLED	~~ENXIO~~	ENODEV	The volume has no work area
FR_NO_FILESYSTEM	~~ENOENT~~	EINVAL	There is no valid FAT volume
FR_MKFS_ABORTED	~~EBADF~~	EIO	The f_mkfs() aborted due to any problem
FR_TIMEOUT	~~EBADF~~	ETIMEDOUT	Could not get a grant to access the volume within defined period
FR_LOCKED	~~EACCES~~	EBUSY	The operation is rejected according to the file sharing policy
FR_NOT_ENOUGH_CORE	ENOMEM	ENOMEM	LFN working buffer could not be allocated
FR_TOO_MANY_OPEN_FILES	ENFILE	ENFILE	Number of open files > FF_FS_LOCK
FR_INVALID_PARAMETER	~~ENOEXEC~~	EINVAL	Given parameter is invalid

cc @kegilbert, @deepikabhavnani, @kjbracey-arm, @JanneKiiskila, @teetak01
intended for minor release
should resolve #6072, #5653

Pull request type

cmonr · 2018-03-21T02:57:01Z

/morph build

mbed-ci · 2018-03-21T03:32:12Z

Build : SUCCESS

Build number : 1502
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6336/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-21T07:10:45Z

Exporter Build : SUCCESS

Build number : 1145
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6336/

mbed-ci · 2018-03-21T09:17:26Z

Test : SUCCESS

Build number : 1285
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6336/1285

0xc0170 · 2018-03-21T13:21:22Z

@JanneKiiskila @yogpan01 to be aware for this change

JanneKiiskila · 2018-03-21T14:00:05Z

Task IOTCLT-2533 raised to our backog.

teetak01 · 2018-03-21T17:07:11Z

I would recommend to keep this PR open until IOTCLT-2533 is done.

cmonr · 2018-03-21T21:31:27Z

Acking the Do Not Merge until the internal ticket is resolved.

JanneKiiskila · 2018-04-18T11:30:30Z

This will be resolved in Cloud Client release 1.3.1, which is due any day now.

geky · 2018-04-29T15:02:02Z

Ok, now this should fix #5653

Also added a fix for some issues with errno include ordering

cmonr · 2018-05-15T15:13:10Z

@geky @JanneKiiskila Is it safe to say that this is now unblocked and can proceed into 5.9?

geky · 2018-05-15T15:28:48Z

@teetak01, can this be progressed?

teetak01 · 2018-05-15T15:39:07Z

http://github.com/armmbed/mbed-cloud-client-example should be compatible. At least it was working one month ago still. The required fix on Client-side was already part of 1.3.1 release.

A lot of the error codes in fatfs were mapped incorrectly. This patch revisits the error code mapping to try to correct these mistakes.

Unfortunately, some toolchains don't define the same errno codes that are used fairly consistently on Linux based platforms, which means they also don't match the errno codes used in the retarget layer. If a user includes errno.h after mbed.h, the errno codes can be redefined incorrectly. Adding an include of errno.h in mbed.h forces the order to be fixed.

The errno.h header file defines the type error_t, unfortunately this is a common type name that may be defined in user code. For at least GCC we can work around this by telling errno that the error_t is already defined.

geky · 2018-05-17T15:27:02Z

Rebased and added a workaround for the error_t conflict

cmonr · 2018-05-17T16:21:20Z

Will restart CI later today. Giving PRs targeted for 5.8.5 a chance to complete.

adbridge · 2018-05-21T13:33:07Z

@kjbracey-arm @cmonr @0xc0170 Are you happy with the updates ? Can you please approve if so?

cmonr · 2018-05-21T22:20:53Z

My bad. Forgot I was a reviewer ^_^

/morph build

mbed-ci · 2018-05-21T23:42:46Z

Build : SUCCESS

Build number : 2089
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6336/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-22T06:34:13Z

Test : SUCCESS

Build number : 1901
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6336/1901

mbed-ci · 2018-05-22T09:57:03Z

Exporter Build : SUCCESS

Build number : 1733
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6336/

0xc0170 · 2018-05-22T11:01:41Z

I would recommend to keep this PR open until IOTCLT-2533 is done.

@teetak01 I checked and its closed. All good for this PR to be approved?

teetak01

should be fine. I only tested the original PR.

geky added BREAKING-CHANGE release-version: 5.9.0-rc1 needs: review labels Mar 12, 2018

0xc0170 previously approved these changes Mar 13, 2018

View reviewed changes

cmonr previously approved these changes Mar 21, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Mar 21, 2018

0xc0170 added ready for merge and removed needs: CI labels Mar 21, 2018

cmonr added the do not merge label Mar 21, 2018

kjbracey previously approved these changes Mar 22, 2018

View reviewed changes

0xc0170 removed the ready for merge label Mar 23, 2018

geky mentioned this pull request Apr 29, 2018

littlefs: Map LFS_ERR_CORRUPT to EILSEQ #6772

Merged

1 task

geky dismissed stale reviews from kjbracey, cmonr, and 0xc0170 via 9902a2b April 29, 2018 15:00

geky mentioned this pull request Apr 29, 2018

remove non empty directory returns inconsistent error codes between LittleFS & FatFS #5653

Closed

geky added 4 commits May 17, 2018 10:26

fatfs: Update error code mapping

6d4190b

A lot of the error codes in fatfs were mapped incorrectly. This patch revisits the error code mapping to try to correct these mistakes.

fatfs: Fixed ENOTEMPTY error for removing a directory

5efda4b

retarget: Added workaround for conflicting definitions of error_t

effdc65

The errno.h header file defines the type error_t, unfortunately this is a common type name that may be defined in user code. For at least GCC we can work around this by telling errno that the error_t is already defined.

geky force-pushed the fat-errors branch from dc32a3d to effdc65 Compare May 17, 2018 15:26

adbridge added needs: review and removed needs: work labels May 21, 2018

cmonr approved these changes May 21, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels May 21, 2018

0xc0170 approved these changes May 22, 2018

View reviewed changes

0xc0170 added needs: review and removed needs: CI labels May 22, 2018

0xc0170 requested a review from teetak01 May 22, 2018 11:02

kjbracey approved these changes May 22, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels May 22, 2018

teetak01 reviewed May 22, 2018

View reviewed changes

0xc0170 merged commit 02af950 into ARMmbed:master May 22, 2018

cmonr removed the ready for merge label May 23, 2018

deepikabhavnani mentioned this pull request Jul 9, 2018

mbed test fails on K64 / IAR PelionIoT/sd-driver#103

Closed

fatfs: Update error code mapping #6336

fatfs: Update error code mapping #6336

Uh oh!

Conversation

geky commented Mar 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

cmonr commented Mar 21, 2018

Uh oh!

mbed-ci commented Mar 21, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Mar 21, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Mar 21, 2018

Test : SUCCESS

Uh oh!

0xc0170 commented Mar 21, 2018

Uh oh!

JanneKiiskila commented Mar 21, 2018

Uh oh!

teetak01 commented Mar 21, 2018

Uh oh!

cmonr commented Mar 21, 2018

Uh oh!

JanneKiiskila commented Apr 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geky commented Apr 29, 2018

Uh oh!

cmonr commented May 15, 2018

Uh oh!

geky commented May 15, 2018

Uh oh!

teetak01 commented May 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geky commented May 17, 2018

Uh oh!

cmonr commented May 17, 2018

Uh oh!

adbridge commented May 21, 2018

Uh oh!

cmonr commented May 21, 2018

Uh oh!

mbed-ci commented May 21, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented May 22, 2018

Test : SUCCESS

Uh oh!

mbed-ci commented May 22, 2018

Exporter Build : SUCCESS

Uh oh!

0xc0170 commented May 22, 2018

Uh oh!

teetak01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

geky commented Mar 12, 2018 •

edited

Loading

JanneKiiskila commented Apr 18, 2018 •

edited

Loading

teetak01 commented May 15, 2018 •

edited

Loading