-
Notifications
You must be signed in to change notification settings - Fork 3k
fatfs: Update error code mapping #6336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
Build : SUCCESSBuild number : 1502 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1145 |
Test : SUCCESSBuild number : 1285 |
@JanneKiiskila @yogpan01 to be aware for this change |
Task IOTCLT-2533 raised to our backog. |
I would recommend to keep this PR open until IOTCLT-2533 is done. |
Acking the Do Not Merge until the internal ticket is resolved. |
This will be resolved in Cloud Client release 1.3.1, which is due any day now. |
Ok, now this should fix #5653 Also added a fix for some issues with errno include ordering |
@geky @JanneKiiskila Is it safe to say that this is now unblocked and can proceed into 5.9? |
@teetak01, can this be progressed? |
http://github.com/armmbed/mbed-cloud-client-example should be compatible. At least it was working one month ago still. The required fix on Client-side was already part of 1.3.1 release. |
A lot of the error codes in fatfs were mapped incorrectly. This patch revisits the error code mapping to try to correct these mistakes.
Unfortunately, some toolchains don't define the same errno codes that are used fairly consistently on Linux based platforms, which means they also don't match the errno codes used in the retarget layer. If a user includes errno.h after mbed.h, the errno codes can be redefined incorrectly. Adding an include of errno.h in mbed.h forces the order to be fixed.
The errno.h header file defines the type error_t, unfortunately this is a common type name that may be defined in user code. For at least GCC we can work around this by telling errno that the error_t is already defined.
Rebased and added a workaround for the |
Will restart CI later today. Giving PRs targeted for 5.8.5 a chance to complete. |
My bad. Forgot I was a reviewer ^_^ /morph build |
Build : SUCCESSBuild number : 2089 Triggering tests/morph test |
Test : SUCCESSBuild number : 1901 |
Exporter Build : SUCCESSBuild number : 1733 |
@teetak01 I checked and its closed. All good for this PR to be approved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine. I only tested the original PR.
Description
Continues #6072, #6120, #6323
A lot of the error codes in fatfs were mapped incorrectly. This patch revisits the error code mapping to try to correct these mistakes.
Note: This is required before we can test LittleFS + FAT consistently
EBADFENOENTENOENTEFAULTENOENTENXIOENOENTEBADFEBADFEACCESENOEXECcc @kegilbert, @deepikabhavnani, @kjbracey-arm, @JanneKiiskila, @teetak01
intended for minor release
should resolve #6072, #5653
Pull request type