Skip to content

Does serial_clear() disable the FIFO? #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamgreen opened this issue Sep 7, 2013 · 1 comment
Closed

Does serial_clear() disable the FIFO? #59

adamgreen opened this issue Sep 7, 2013 · 1 comment

Comments

@adamgreen
Copy link
Contributor

As I was code reviewing the serial_api.c source code for the LPC176X port, I noticed the following code in serial_clear():

void serial_clear(serial_t *obj) {
    obj->uart->FCR = 1 << 1  // rx FIFO reset
                   | 1 << 2  // tx FIFO reset
                   | 0 << 6; // interrupt depth
}

I never see this API being called from any code in the mbed SDK but if it was called, wouldn't it end up disabling the FIFO as it does not keep bit 0, the FIFO enable bit, set high?

@bogdanm
Copy link
Contributor

bogdanm commented Sep 9, 2013

Thanks for the report! I'll fix this.

@bogdanm bogdanm closed this as completed Sep 9, 2013
bridadan pushed a commit that referenced this issue Jun 21, 2016
Fixes #59 - build and make - handle toolchain/target name errors
hasnainvirk pushed a commit to hasnainvirk/mbed-os that referenced this issue Feb 12, 2017
… from a1982c1..e125164

e125164 Check secure session pointer in timer callback (ARMmbed#61)
f49e596 Update unit tests (ARMmbed#59)
6a5634a Support for multiple virtual services (ARMmbed#58)
7fe6b98 Remove yotta files (ARMmbed#57)
5c5c8fe Fix socket send return value overflow (ARMmbed#56)
0870d05 Update unit test stubs to match latest socket api (ARMmbed#55)
e687be8 Merge pull request ARMmbed#54 from ARMmbed/warn_fixes
b8fe613 updated unittests
8640d05 Compilation warnings fixed
eea83e5 Flag out entropy source addition (ARMmbed#53)
7d72eb4 Fix unittests (ARMmbed#52)
4a6991e Avoid referencing ns_msghdr_t::flags

git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/coap-service
git-subtree-split: e125164
kjbracey added a commit to kjbracey/mbed-os that referenced this issue Jul 6, 2017
…from 6444c8a..854505d

854505d Introduce object oriented dynmemLIB
27bae6b Merge pull request ARMmbed#59 from ARMmbed/fix_yotta_deps
ff45891 Add dependency on mbed-trace

git-subtree-dir: features/FEATURE_COMMON_PAL/nanostack-libservice
git-subtree-split: 854505d0191e428c07eb25fc9630dc05b21d5a47
0xc0170 pushed a commit that referenced this issue Jul 28, 2017
…from 6444c8a..854505d

854505d Introduce object oriented dynmemLIB
27bae6b Merge pull request #59 from ARMmbed/fix_yotta_deps
ff45891 Add dependency on mbed-trace

git-subtree-dir: features/FEATURE_COMMON_PAL/nanostack-libservice
git-subtree-split: 854505d0191e428c07eb25fc9630dc05b21d5a47
geky added a commit to geky/mbed that referenced this issue Aug 25, 2018
linlingao added a commit to linlingao/mbed-os that referenced this issue Jul 12, 2019
pan- added a commit to pan-/mbed that referenced this issue May 29, 2020
Fix#58: Inprove portability of BLE_URIBeacon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants