Skip to content

lorawan interface connect method should return LORAWAN_CONNECT_IN_PROCESS when connnecting #7230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garycolecd opened this issue Jun 15, 2018 · 3 comments
Closed

lorawan interface connect method should return LORAWAN_CONNECT_IN_PROCESS when connnecting #7230

garycolecd opened this issue Jun 15, 2018 · 3 comments

Comments

@garycolecd
Copy link

garycolecd commented Jun 15, 2018 •
edited
Loading

Description

LoraWANInterface::connect returns LORAWAN_STATUS_OK when idle and entering connecting state. An asynchronous event is sent when connection completes or fails. If the stack is already connected the connect method also returns LORAWAN_STATUS_OK, but does not send an asynchronous event. The application cannot distinguish the two use cases without timing out waiting for the event.

Issue request type

The stack includes the LORAWAN_STATUS_CONNECT_IN_PROGESS result code, but it does not appear to be used in mbed-os-5.9.0. The connect method should return LORAWAN_STATUS_CONNECT_IN_PROGESS when it will notify the application with an event, and return LORAWAN_STATUS_OK when the stack is already connected.

[ ] Question
[X] Enhancement
[ ] Bug
@ciarmcom
Copy link
Member

ARM Internal Ref: MBOTRIAGE-724

hasnainvirk pushed a commit to hasnainvirk/mbed-os that referenced this issue Jul 9, 2018
LoRaWAN: Handling re-joining when already Joined
51f92b0 
This is a remedy for the issue ARMmbed#7230.
While the device is joining, LORAWAN_STATUS_CONNECT_IN_PROGRESS is returned.
However, if the device is already joined, we will return LORAWAN_STATUS_ALREADY_CONNECTED.
@hasnainvirk hasnainvirk mentioned this issue Jul 9, 2018
Merged
@hasnainvirk
Copy link
Contributor

@garycolecd Please check the remedy for the issue. Thank you for your collaboration.
#7445. The change will take effect from Mbed OS 5.10 release. However, you can cherry-pick for your use whenever you wish.

@garycolecd
Copy link
Author

Issue resolved with API changes, thanks.

cmonr pushed a commit that referenced this issue Jul 13, 2018
Merge pull request #7445 from hasnainvirk/issue_7230
c5ba97f 
LoRaWAN: Remedy for issue #7230
cmonr pushed a commit that referenced this issue Jul 15, 2018
LoRaWAN: Handling re-joining when already Joined
2d4270a 
This is a remedy for the issue #7230.
While the device is joining, LORAWAN_STATUS_CONNECT_IN_PROGRESS is returned.
However, if the device is already joined, we will return LORAWAN_STATUS_ALREADY_CONNECTED.
cmonr pushed a commit that referenced this issue Jul 16, 2018
LoRaWAN: Handling re-joining when already Joined
3cf1d54 
This is a remedy for the issue #7230.
While the device is joining, LORAWAN_STATUS_CONNECT_IN_PROGRESS is returned.
However, if the device is already joined, we will return LORAWAN_STATUS_ALREADY_CONNECTED.
cmonr pushed a commit that referenced this issue Jul 16, 2018
LoRaWAN: Handling re-joining when already Joined
b6fbb97 
This is a remedy for the issue #7230.
While the device is joining, LORAWAN_STATUS_CONNECT_IN_PROGRESS is returned.
However, if the device is already joined, we will return LORAWAN_STATUS_ALREADY_CONNECTED.
pan- pushed a commit to pan-/mbed that referenced this issue Aug 22, 2018
LoRaWAN: Handling re-joining when already Joined
a8da345 
This is a remedy for the issue ARMmbed#7230.
While the device is joining, LORAWAN_STATUS_CONNECT_IN_PROGRESS is returned.
However, if the device is already joined, we will return LORAWAN_STATUS_ALREADY_CONNECTED.
pan- pushed a commit to pan-/mbed that referenced this issue Aug 22, 2018
Merge pull request ARMmbed#7445 from hasnainvirk/issue_7230
2e820e1 
LoRaWAN: Remedy for issue ARMmbed#7230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hasnainvirk @ciarmcom @garycolecd