Skip to content

PSA: release.py - add build profile #10001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

PSA: release.py - add build profile #10001

merged 1 commit into from
Mar 8, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Mar 7, 2019

Description

  • Add --debug flag to release.py
  • Set default build profile to release for both tests & official image.

Cant believe i missed PR 10000 😭😭😭😭😭😭😭😭

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@orenc17
Add build profile option
9a3ab49 
Default set to release
ghost
ghost approved these changes Mar 7, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets criteria, fix for new feature. Approved.

@ghost ghost added the PM_ACCEPTED label Mar 7, 2019
@cmonr
Copy link
Contributor

cmonr commented Mar 8, 2019

Cant believe i missed PR 10000 sobsobsobsobsobsobsobsob

Sounds like someone was trying.

Next time, make a script that uses the GitHub API ;)

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit b582c54 into ARMmbed:master Mar 8, 2019
@orenc17 orenc17 mentioned this pull request Mar 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.12.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orenc17 @cmonr @0xc0170 @mbed-ci @NirSonnenschein