Skip to content

Cellular: Remove compile dependency of UARTSerial #10029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2019
Merged

Cellular: Remove compile dependency of UARTSerial #10029

merged 1 commit into from
Mar 18, 2019

Conversation

AriParkkila
Copy link

Description

Fix issue #9848.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jarvte

Release Notes

@AriParkkila AriParkkila mentioned this pull request Mar 11, 2019
Closed
@ciarmcom ciarmcom requested review from jarvte and a team March 11, 2019 12:00
@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@jarvte @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team March 11, 2019 12:00
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 11, 2019

The commit msg/title misleads a bit - we are not removing here the dependency rather adding the dependency requirement ?

@jeromecoutant
Copy link
Collaborator

It is difficult to approve the change before #9850 patch proposal...

And I agree with Martin, you are not removing DEVICE_SERIAL dependency, you are adding some dependency?

jeromecoutant
jeromecoutant suggested changes Mar 12, 2019
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add also some DEVICE_INTERRUPTIN dependency

@AriParkkila AriParkkila force-pushed the cellular-device_serial branch from fc9292d to 903a6f2 Compare March 13, 2019 06:59
@AriParkkila
Copy link
Author

@0xc0170 @jeromecoutant Changed commit message and added ifdef for DEVICE_INTERRUPTIN.

@AriParkkila AriParkkila changed the title Cellular: Remove DEVICE_SERIAL dependency Cellular: Remove compile dependency of UARTSerial Mar 13, 2019
@0xc0170 0xc0170 requested a review from a team March 14, 2019 11:05
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

Build all OK, had to abort the rest of the pipeline to allow rc3 jobs in now. will restart once we can

@mbed-ci
Copy link

mbed-ci commented Mar 14, 2019

Test run: FAILED

Summary: 4 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@NirSonnenschein
Copy link
Contributor

possible ARMC6 license failure, restarting CI

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2019

Test run: FAILED

Summary: 2 of 13 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_exporter

@NirSonnenschein
Copy link
Contributor

restarting cloud client test and exporters

@0xc0170 0xc0170 merged commit 4cf22b3 into ARMmbed:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AriParkkila @ciarmcom @0xc0170 @jeromecoutant @mbed-ci @NirSonnenschein @AnttiKauppila @jarvte